From: will.deacon@arm•com (Will Deacon)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/2] arm64: Refactor vDSO time functions
Date: Mon, 11 Jul 2016 18:42:25 +0100 [thread overview]
Message-ID: <20160711174224.GA21493@arm.com> (raw)
In-Reply-To: <a3eda01b-b835-c20c-a39d-efc8853b00f8@arm.com>
On Mon, Jul 11, 2016 at 06:31:16PM +0100, Kevin Brodsky wrote:
> On 08/07/16 15:11, Will Deacon wrote:
> >Fixup patch below. If you fold it in, then:
> >
> >Acked-by: Will Deacon <will.deacon@arm•com>
> >
> >for the series.
>
> I just have one small concern with your fixup patch: the ALIGN macro from
> linkage.h (not the one from kernel.h, which is for C, not assembly) uses
> 0x90 as padding, which apparently is NOP on x86 but does not make much sense
> on ARM64 (or ARM for that matter). It is not currently used in arm{,64}. I
> am not sure if it could decode to a valid instruction on ARM64, but maybe
> using simply 0x0 as a padding byte would be less arbitrary. I also don't
> like this ALIGN macro too much, because the "4" argument means something
> different depending on the architecture (4 bytes on x86, 2^4 on arm*:
> https://sourceware.org/binutils/docs/as/Align.html).
ALIGN expands to __ALIGN which is defined in
arch/arm64/include/asm/linkage.h as .align 4.
You're 4 years late ;)
http://git.kernel.org/linus/aeed41a9371e
Will
next prev parent reply other threads:[~2016-07-11 17:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-09 12:36 [PATCH 0/2] arm64: Add support for CLOCK_MONOTONIC_RAW in clock_gettime() vDSO Kevin Brodsky
2016-05-09 12:37 ` [PATCH 1/2] arm64: Refactor vDSO time functions Kevin Brodsky
2016-06-22 13:24 ` Christopher Covington
2016-07-01 13:46 ` Dave Martin
2016-07-04 17:12 ` Will Deacon
2016-07-08 14:11 ` Will Deacon
2016-07-11 17:31 ` Kevin Brodsky
2016-07-11 17:42 ` Will Deacon [this message]
2016-07-12 9:10 ` Kevin Brodsky
2016-05-09 12:37 ` [PATCH 2/2] arm64: Add support for CLOCK_MONOTONIC_RAW in clock_gettime() vDSO Kevin Brodsky
2016-07-01 13:48 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160711174224.GA21493@arm.com \
--to=will.deacon@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox