From: will.deacon@arm•com (Will Deacon)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] drivers/perf: arm-pmu: Fix handling of SPI lacking "interrupt-affinity" property
Date: Tue, 30 Aug 2016 18:27:10 +0100 [thread overview]
Message-ID: <20160830172710.GJ24906@arm.com> (raw)
In-Reply-To: <CAOi56cXFCZoMox3XrJvsQAXHa1uxOBPEKO266B2yYONv3pTY7g@mail.gmail.com>
Hi Kevin,
Thanks for reporting this.
On Fri, Aug 26, 2016 at 12:11:55PM -0500, Kevin Hilman wrote:
> On Tue, Jul 19, 2016 at 9:39 AM, Marc Zyngier <marc.zyngier@arm•com> wrote:
> > Patch 19a469a58720 ("drivers/perf: arm-pmu: Handle per-interrupt
> > affinity mask") added support for partitionned PPI setups, but
> > inadvertently broke setups using SPIs without the "interrupt-affinity"
> > property (which is the case for UP platforms).
> >
> > This patch restore the broken functionnality by testing whether the
> > interrupt is percpu or not instead of relying on the using_spi flag
> > that really means "SPI *and* interrupt-affinity property".
> >
> > Reported-by: Geert Uytterhoeven <geert@linux-m68k•org>
> > Tested-by: Geert Uytterhoeven <geert@linux-m68k•org>
> > Fixes: 19a469a58720 ("drivers/perf: arm-pmu: Handle per-interrupt affinity mask")
> > Signed-off-by: Marc Zyngier <marc.zyngier@arm•com>
>
> kernelci.org detected boot failures on bcm2835-rpi-b in mainline[1]
> and was bisected down to this patch. I verified that reverting this
> patch on top of mainline gets bcm2835-rpi-b booting again.
>
> I haven't been closely tracking this change, but a quick glance and it
> looks like this platform is possibly missing IRQ properties from its
> PMU node? The DT for this platform simply has:
>
> arm-pmu {
> compatible = "arm,arm1176-pmu";
> };
Stefan Wahren posted a fix for this, so I've queued it locally and plan
to send via Catalin:
http://lists.infradead.org/pipermail/linux-arm-kernel/2016-August/452475.html
Will
prev parent reply other threads:[~2016-08-30 17:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-19 14:39 [PATCH] drivers/perf: arm-pmu: Fix handling of SPI lacking "interrupt-affinity" property Marc Zyngier
2016-07-19 16:23 ` Will Deacon
2016-08-26 17:11 ` Kevin Hilman
2016-08-30 17:27 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160830172710.GJ24906@arm.com \
--to=will.deacon@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox