From: greg@kroah•com (Greg KH)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 0/3] arm64: kgdb: fix single stepping
Date: Fri, 23 Sep 2016 10:43:41 +0200 [thread overview]
Message-ID: <20160923084341.GA32342@kroah.com> (raw)
In-Reply-To: <20160923083257.GL30248@linaro.org>
On Fri, Sep 23, 2016 at 05:32:58PM +0900, AKASHI Takahiro wrote:
> On Fri, Sep 23, 2016 at 10:16:18AM +0200, Greg KH wrote:
> > On Fri, Sep 23, 2016 at 04:33:24PM +0900, AKASHI Takahiro wrote:
> > > Kgdb support on arm64 was merged in v3.15, but from its first appearance,
> > > "signle step" has never worked well.
> > >
> > > This patch fixes all the error cases I found so far.
> > > The original patch[1] was splitted into three pieces, ones for each case.
> > > patch#1, #2 should be applied to all the version, v3.15 and later.
> > > pathc#3 only for v3.16 and later.
> >
> > As this is not a regression (i.e. it has never worked), why is this
> > something for stable releases?
>
> Because, I think, that is a bug.
> The author seems to have believed that it worked.
> Please see:
> commit 44679a4f
> Author: Vijaya Kumar K <Vijaya.Kumar@caviumnetworks•com>
> Date: Tue Jan 28 11:20:19 2014 +0000
>
> arm64: KGDB: Add step debugging support
Yes, but again, it didn't work, so this would be a new feature. One
that obviously people aren't using in the stable kernels, otherwise they
would have noticed in the past 2 years about it being broken :)
Please read Documentation/stable_kernel_rules.txt for the requirements
of a stable kernel patch. I don't think this series meets those rules.
thanks,
greg k-h
next prev parent reply other threads:[~2016-09-23 8:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-23 7:33 [PATCH v2 0/3] arm64: kgdb: fix single stepping AKASHI Takahiro
2016-09-23 7:33 ` [PATCH v2 1/3] " AKASHI Takahiro
2016-09-23 7:33 ` [PATCH v2 2/3] arm64: kgdb: prevent kgdb from being invoked recursively AKASHI Takahiro
2016-09-23 10:02 ` Will Deacon
2016-09-23 7:33 ` [PATCH v2 3/3] arm64: kgdb: disable interrupts while a software step is enabled AKASHI Takahiro
2016-09-23 8:16 ` [PATCH v2 0/3] arm64: kgdb: fix single stepping Greg KH
2016-09-23 8:32 ` AKASHI Takahiro
2016-09-23 8:43 ` Greg KH [this message]
2016-09-23 9:27 ` AKASHI Takahiro
2016-09-23 9:23 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160923084341.GA32342@kroah.com \
--to=greg@kroah$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox