From: thomas.petazzoni@free-electrons•com (Thomas Petazzoni)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 03/14] ASoC: sun4i-i2s: Add apb reset
Date: Tue, 4 Oct 2016 14:15:16 +0200 [thread overview]
Message-ID: <20161004141516.53c6fa8c@free-electrons.com> (raw)
In-Reply-To: <2c5abe6578c8e4e841cb59357d88ce397551a593.1475571575.git.mylene.josserand@free-electrons.com>
Hello,
On Tue, 4 Oct 2016 11:46:16 +0200, Myl?ne Josserand wrote:
> #include <sound/dmaengine_pcm.h>
> #include <sound/pcm_params.h>
> @@ -589,6 +590,7 @@ static int sun4i_i2s_probe(struct platform_device *pdev)
> {
> struct sun4i_i2s *i2s;
> struct resource *res;
> + struct reset_control *reset_apb;
> void __iomem *regs;
> int irq, ret;
>
> @@ -626,7 +628,19 @@ static int sun4i_i2s_probe(struct platform_device *pdev)
> dev_err(&pdev->dev, "Can't get our mod clock\n");
> return PTR_ERR(i2s->mod_clk);
> }
> -
> +
> + reset_apb = devm_reset_control_get(&pdev->dev, "apb_reset");
I believe this is a change in the Device Tree binding, since you're
adding support for a new resource. Perhaps the Device Tree binding
documentation should be updated accordingly?
> + if (IS_ERR(reset_apb)) {
> + dev_err(&pdev->dev, "Can't get apb reset\n");
> + return PTR_ERR(i2s->mod_clk);
This should be:
return PTR_ERR(reset_apb);
> + }
> +
> + ret = reset_control_deassert(reset_apb);
> + if (ret < 0) {
> + dev_err(&pdev->dev, "Can't deassert apb reset (%d)\n", ret);
> + return ret;
> + }
Do you need to re-assert the reset line in the ->remove() hook?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-10-04 12:15 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1475571575.git.mylene.josserand@free-electrons.com>
2016-10-04 9:46 ` [PATCH 00/14] ASoc: sunxi: Add Allwinner A33 codec driver Mylène Josserand
2016-10-04 9:46 ` [PATCH 01/14] dma: sun6i-dma: Add burst case of 4 Mylène Josserand
2016-10-04 10:40 ` Jean-Francois Moine
2016-10-04 12:12 ` Thomas Petazzoni
2016-10-04 13:46 ` Jean-Francois Moine
2016-10-04 15:40 ` Vinod Koul
2016-10-04 16:55 ` Maxime Ripard
2016-10-23 16:31 ` Jean-Francois Moine
2016-10-27 17:51 ` Maxime Ripard
2016-10-30 2:06 ` Chen-Yu Tsai
2016-10-30 6:16 ` Jean-Francois Moine
2016-11-01 13:46 ` Koul, Vinod
2016-11-01 14:55 ` Chen-Yu Tsai
2016-11-14 4:54 ` Vinod Koul
2016-10-04 9:46 ` [PATCH 02/14] clk: ccu-sun8i-a33: Add CLK_SET_RATE_PARENT to ac-dig Mylène Josserand
2016-10-04 12:12 ` Thomas Petazzoni
2016-10-05 9:37 ` Mylene Josserand
2016-10-04 9:46 ` [PATCH 03/14] ASoC: sun4i-i2s: Add apb reset Mylène Josserand
2016-10-04 12:15 ` Thomas Petazzoni [this message]
2016-10-04 15:42 ` Maxime Ripard
2016-10-05 9:43 ` Mylene Josserand
2016-10-04 12:22 ` Code Kipper
2016-10-04 9:46 ` [PATCH 04/14] ASoC: Add sun8i analog codec driver Mylène Josserand
2016-10-04 10:21 ` Code Kipper
2016-10-04 10:56 ` Chen-Yu Tsai
2016-10-04 9:46 ` [PATCH 05/14] mfd: sun6i-prcm: Add sun8i analog codec as subnode Mylène Josserand
2016-10-04 10:52 ` Jean-Francois Moine
2016-10-26 14:05 ` Lee Jones
2016-10-04 9:46 ` [PATCH 06/14] ASoC: Add sun8i digital audio codec Mylène Josserand
2016-10-04 12:40 ` Thomas Petazzoni
2016-10-04 13:07 ` Mark Brown
2016-10-04 13:16 ` Thomas Petazzoni
2016-10-04 16:09 ` Maxime Ripard
2016-10-05 11:54 ` Mylene Josserand
2016-10-04 16:15 ` Maxime Ripard
2016-10-06 16:06 ` Icenowy Zheng
2016-10-06 18:23 ` Alexandre Belloni
2016-10-05 10:19 ` Icenowy Zheng
2016-10-04 9:46 ` [PATCH 07/14] ASoC: Add sun8i audio card Mylène Josserand
2016-10-04 10:16 ` Code Kipper
2016-10-04 10:59 ` Chen-Yu Tsai
2016-10-04 12:25 ` Thomas Petazzoni
2016-10-05 6:04 ` Code Kipper
2016-10-05 10:03 ` Jean-Francois Moine
2016-10-04 9:46 ` [PATCH 08/14] dt-bindings: sound: Add sun8i analog codec documentation Mylène Josserand
2016-10-04 10:32 ` Mark Brown
2016-10-04 16:24 ` Maxime Ripard
2016-10-05 2:59 ` Chen-Yu Tsai
2016-10-05 12:08 ` Mylene Josserand
2016-10-04 9:46 ` [PATCH 09/14] dt-bindings: sound: Add sun8i " Mylène Josserand
2016-10-04 16:19 ` Maxime Ripard
2016-10-04 9:46 ` [PATCH 10/14] dt-bindings: sound: Add sun8i audio card documentation Mylène Josserand
2016-10-04 16:32 ` Maxime Ripard
2016-10-04 9:46 ` [PATCH 11/14] ARM: dts: sun8i: Add analog codec on prcm node Mylène Josserand
2016-10-04 9:46 ` [PATCH 12/14] ARM: dts: sun8i: Add audio codec, dai and card for A33 Mylène Josserand
2016-10-04 9:46 ` [PATCH 13/14] ARM: dts: sun8i: parrot: Enable audio nodes Mylène Josserand
2016-10-04 9:46 ` [PATCH 14/14] ARM: dts: sun8i: sinlinx: " Mylène Josserand
2016-10-07 8:35 ` [PATCH 00/14] ASoc: sunxi: Add Allwinner A33 codec driver Icenowy Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161004141516.53c6fa8c@free-electrons.com \
--to=thomas.petazzoni@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox