From: emil@limesaudio•com (Emil Lundmark)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 1/2] clk: imx: fix integer overflow in AV PLL round rate
Date: Tue, 11 Oct 2016 11:58:52 +0200 [thread overview]
Message-ID: <20161011095852.GB8477@lime> (raw)
In-Reply-To: <CAOMZO5C56tiXjBArgqZuMdu8_MB6Gq3=xWX65WNvQv+=r6VjGQ@mail.gmail.com>
On Mon, Oct 10, 2016 at 11:08:40AM -0300, Fabio Estevam wrote:
> On Mon, Oct 10, 2016 at 7:03 AM, Emil Lundmark <emil@limesaudio•com> wrote:
> > Since 'parent_rate * mfn' may overflow 32 bits, the result should be
> > stored using 64 bits.
>
> It would be nice to add the text you put in the cover letter where you
> explain the PLL4 clock discrepancy here in the commit log.
I will do that in v3.
> >
> > Fixes: ba7f4f557eb6 ("clk: imx: correct AV PLL rate formula")
>
> Would be nice to Cc the author of this commit (Anson Huang). Added on Cc.
Good point, will keep this in mind in the future.
> Another hint: ./scripts/get_maintainer.pl drivers/clk/imx/clk-pllv3.c
> gives you some suggestions on people and lists to add to Cc.
I did that, but read somewhere that you should send it to the maintainers
and CC the appropriate list. Should I also send it to reviewers?
Since this patch series only affects i.MX, I chose to not include the
people from the common clock framework. Was that wrong?
--
Emil Lundmark
next prev parent reply other threads:[~2016-10-11 9:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-10 10:03 [PATCH v2 0/2] clk: imx: fix AV PLL rate setting Emil Lundmark
2016-10-10 10:03 ` [PATCH v2 1/2] clk: imx: fix integer overflow in AV PLL round rate Emil Lundmark
2016-10-10 13:54 ` Uwe Kleine-König
2016-10-11 9:52 ` Emil Lundmark
2016-10-10 14:08 ` Fabio Estevam
2016-10-11 9:58 ` Emil Lundmark [this message]
2016-10-11 10:42 ` Fabio Estevam
2016-10-10 10:03 ` [PATCH v2 2/2] clk: imx: improve precision of AV PLL to 1 Hz Emil Lundmark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161011095852.GB8477@lime \
--to=emil@limesaudio$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox