From: horms@verge•net.au (Simon Horman)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v4 00/23] soc: renesas: Add R-Car RST driver for obtaining mode pin state
Date: Mon, 31 Oct 2016 09:19:24 +0100 [thread overview]
Message-ID: <20161031081923.GF18195@verge.net.au> (raw)
In-Reply-To: <CAMuHMdVbpuv94x-ocTSDoEj+SbnESDbkuMXsXExQvoyZepp+Zg@mail.gmail.com>
On Wed, Oct 26, 2016 at 02:00:24PM +0200, Geert Uytterhoeven wrote:
> Hi Mike, Stephen,
>
> On Fri, Oct 21, 2016 at 3:17 PM, Geert Uytterhoeven
> <geert+renesas@glider•be> wrote:
> > Currently the R-Car Clock Pulse Generator (CPG) drivers obtains the
> > state of the mode pins either by a call from the platform code, or
> > directly by using a hardcoded register access. This is a bit messy, and
> > creates a dependency between driver and platform code.
> >
> > This patch series converts the various Renesas R-Car clock drivers
> > and support code from reading the mode pin states using a hardcoded
> > register access to using a new minimalistic R-Car RST driver.
> >
> > All R-Car clock drivers will rely on the presence in DT of a device node
> > for the RST module. Backwards compatibility with old DTBs is retained
> > only for R-Car Gen2, which has fallback code using its own private copy
> > of rcar_gen2_read_mode_pins().
> >
> > After this, there is still one remaining user of
> > rcar_gen2_read_mode_pins() left in platform code. A patch series to
> > remove that user has already been posted, though ("[PATCH/RFT 0/4] ARM:
> > shmobile: R-Car Gen2: Allow booting secondary CPU cores in debug mode").
> > Since v3, the other user has been removed in commit 9f5ce39ddb8f68b3
> > ("ARM: shmobile: rcar-gen2: Obtain extal frequency from DT").
> >
> > This series consists of 5 parts:
> > A. Patches 1 and 2 add DT bindings and driver code for the R-Car RST
> > driver,
> > B. Patches 3-11 add device nodes for the RST modules to the R-Car DTS
> > files,
> > C. Patches 12-17 convert the clock drivers to call into the new R-Car
> > RST driver,
> > D. Patches 18-20 remove passing mode pin state to the clock drivers
> > from the platform code,
> > E. Patches 21-23 remove dead code from the clock drivers.
> >
> > As is usually the case with moving functionality from platform code to
> > DT, there are lots of hard dependencies:
> > - The DT updates in Part B can be merged as soon as the DT bindings in
> > Part A have been approved,
> > - The clock driver updates in Part C depend functionally on the driver
> > code in Part A, and on the DT updates in Part B,
> > - The board code cleanups in Part D depend on the clock driver updates
> > in Part C,
> > - The block driver cleanups in part E depend on the board code
> > cleanups in part D.
> >
> > Hence to maintain the required lockstep between SoC driver, clock
> > drivers, shmobile platform code, and shmobile DT, I propose to queue up
> > all patches in a single branch against v4.9-rc1, and send pull requests
> > to both Mike/Stephen (clock) and Simon (rest).
> >
> > ***
>
> > - Mike/Stephen/Simon/Magnus: Are you OK with the suggested merge
> > approach above?
>
> Is this OK for you?
>
> I'd like to move forward with this, as this is a prerequisite for adding
> support for new SoCs (RZ/G) without adding more copies of
> rcar_gen2_read_mode_pins(), and removing that function from platform code
> for good.
This seems reasonable to me but likely the ARM SoC maintainers will want to
know about this plan before it is executed.
next prev parent reply other threads:[~2016-10-31 8:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-21 13:17 [PATCH v4 00/23] soc: renesas: Add R-Car RST driver for obtaining mode pin state Geert Uytterhoeven
2016-10-21 13:17 ` [PATCH v4 02/23] soc: renesas: Add R-Car RST driver Geert Uytterhoeven
2016-10-21 13:17 ` [PATCH v4 07/23] ARM: dts: r8a7792: Add device node for RST module Geert Uytterhoeven
2016-10-21 13:17 ` [PATCH v4 10/23] arm64: renesas: r8a7795 dtsi: " Geert Uytterhoeven
2016-10-21 13:17 ` [PATCH v4 11/23] arm64: renesas: r8a7796 " Geert Uytterhoeven
2016-10-21 13:17 ` [PATCH v4 13/23] clk: renesas: r8a7779: Obtain mode pin values from R-Car RST driver Geert Uytterhoeven
2016-10-21 13:17 ` [PATCH v4 14/23] clk: renesas: rcar-gen2: Obtain mode pin values using " Geert Uytterhoeven
2016-10-21 13:17 ` [PATCH v4 15/23] clk: renesas: r8a7795: Obtain mode pin values from R-Car " Geert Uytterhoeven
2016-10-21 13:17 ` [PATCH v4 19/23] ARM: shmobile: r8a7779: Stop passing mode pins state to clock driver Geert Uytterhoeven
2016-10-21 13:17 ` [PATCH v4 21/23] clk: renesas: r8a7778: Remove obsolete r8a7778_clocks_init() Geert Uytterhoeven
2016-10-21 13:17 ` [PATCH v4 22/23] clk: renesas: r8a7779: Remove obsolete r8a7779_clocks_init() Geert Uytterhoeven
2016-10-21 13:17 ` [PATCH v4 23/23] clk: renesas: rcar-gen2: Remove obsolete rcar_gen2_clocks_init() Geert Uytterhoeven
2016-10-21 15:45 ` [PATCH v4 00/23] soc: renesas: Add R-Car RST driver for obtaining mode pin state Philipp Zabel
2016-10-21 15:47 ` Philipp Zabel
2016-10-26 11:56 ` Geert Uytterhoeven
[not found] ` <1477055857-17936-2-git-send-email-geert+renesas@glider.be>
2016-10-21 15:48 ` [PATCH v4 01/23] reset: Add renesas,rst DT bindings Philipp Zabel
2016-10-30 20:41 ` Rob Herring
2016-10-26 12:00 ` [PATCH v4 00/23] soc: renesas: Add R-Car RST driver for obtaining mode pin state Geert Uytterhoeven
2016-10-31 8:19 ` Simon Horman [this message]
2016-10-31 8:32 ` Geert Uytterhoeven
2016-10-31 23:25 ` Stephen Boyd
2016-11-02 9:02 ` Geert Uytterhoeven
2016-11-04 19:49 ` Stephen Boyd
2016-11-07 9:30 ` Geert Uytterhoeven
[not found] ` <1477055857-17936-21-git-send-email-geert+renesas@glider.be>
2016-11-01 13:35 ` [PATCH v4 20/23] ARM: shmobile: rcar-gen2: Stop passing mode pins state to clock driver Sergei Shtylyov
2016-11-02 8:09 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161031081923.GF18195@verge.net.au \
--to=horms@verge$(echo .)net.au \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox