From: arnd@arndb•de (Arnd Bergmann)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/3] ipmi/bt-bmc: change compatible node to 'aspeed, ast2400-ibt-bmc'
Date: Wed, 2 Nov 2016 14:15:50 +0100 [thread overview]
Message-ID: <201611021415.51081.arnd@arndb.de> (raw)
In-Reply-To: <1478073426-3714-2-git-send-email-clg@kaod.org>
On Wednesday 02 November 2016, C?dric Le Goater wrote:
> The Aspeed SoCs have two BT interfaces : one is IPMI compliant and the
> other is H8S/2168 compliant.
>
> The current ipmi/bt-bmc driver implements the IPMI version and we
> should reflect its nature in the compatible node name using
> 'aspeed,ast2400-ibt-bmc' instead of 'aspeed,ast2400-bt-bmc'. The
> latter should be used for a H8S interface driver if it is implemented
> one day.
>
> Signed-off-by: C?dric Le Goater <clg@kaod•org>
We generally try to avoid changing the compatible strings after the
fact, but it's probably ok in this case.
I don't understand who decides which of the two interfaces is used:
is it the same register set that can be driven by either one or the
other driver, or do you expect to have two drivers that can both
be active in the same system and talk to different hardware once
you get there?
If the first one of these is true, it seems a little awkward to
use the DT compatible string to decide which driver to use rather
than making the decision in the OS.
Arnd
next prev parent reply other threads:[~2016-11-02 13:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-02 7:57 [PATCH 0/3] ipmi/bt-bmc: fix compatible node and add a request expiry list Cédric Le Goater
2016-11-02 7:57 ` [PATCH 1/3] ipmi/bt-bmc: change compatible node to 'aspeed, ast2400-ibt-bmc' Cédric Le Goater
2016-11-02 13:15 ` Arnd Bergmann [this message]
2016-11-02 13:56 ` Joel Stanley
2016-11-02 14:28 ` [PATCH 1/3] ipmi/bt-bmc: change compatible node to 'aspeed,ast2400-ibt-bmc' Cédric Le Goater
2016-11-07 13:02 ` [PATCH 1/3] ipmi/bt-bmc: change compatible node to 'aspeed, ast2400-ibt-bmc' Arnd Bergmann
2016-11-08 15:52 ` [PATCH 1/3] ipmi/bt-bmc: change compatible node to 'aspeed,ast2400-ibt-bmc' Cédric Le Goater
2016-11-08 18:15 ` Corey Minyard
2016-11-09 16:09 ` [PATCH 1/3] ipmi/bt-bmc: change compatible node to 'aspeed, ast2400-ibt-bmc' Arnd Bergmann
2016-11-10 2:49 ` Joel Stanley
2016-11-18 0:33 ` [PATCH 1/3] ipmi/bt-bmc: change compatible node to 'aspeed,ast2400-ibt-bmc' Olof Johansson
2016-11-09 18:26 ` [PATCH 1/3] ipmi/bt-bmc: change compatible node to 'aspeed, ast2400-ibt-bmc' Rob Herring
2016-11-02 7:57 ` [PATCH 2/3] ipmi/bt-bmc: maintain a request expiry list Cédric Le Goater
2016-11-07 19:04 ` Corey Minyard
2016-11-09 14:30 ` Cédric Le Goater
2016-11-09 15:52 ` Corey Minyard
2016-11-09 19:08 ` Cédric Le Goater
2016-11-02 7:57 ` [PATCH 3/3] ipmi/bt-bmc: add a sysfs file to configure a maximum response time Cédric Le Goater
2016-11-07 18:37 ` Corey Minyard
2016-11-09 14:42 ` Cédric Le Goater
2016-11-09 16:04 ` Corey Minyard
2016-11-10 2:46 ` Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201611021415.51081.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox