From: arnd@arndb•de (Arnd Bergmann)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH RFC 1/7] dma: pl08x: Add support for the DMA slave map
Date: Sat, 5 Nov 2016 00:26:49 +0100 [thread overview]
Message-ID: <201611050026.49560.arnd@arndb.de> (raw)
In-Reply-To: <1478276094-19135-3-git-send-email-s.nawrocki@samsung.com>
On Friday 04 November 2016, Sylwester Nawrocki wrote:
> + } else {
> + pl08x->slave.filter.map = pl08x->pd->slave_map;
> + pl08x->slave.filter.mapcnt = pl08x->pd->slave_map_len;
> }
I think you miss the setup of the filter function here.
Filtering by string in this driver is a bit awkward, so I wonder if we
might want to go one step further here and pass the actual data (i.e.
struct pl08x_channel_data) rather than the string here.
Arnd
next prev parent reply other threads:[~2016-11-04 23:26 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-04 16:14 [PATCH RFC 0/7] DMA: S3C64XX: Conversion to the new channel request API Sylwester Nawrocki
2016-11-04 16:14 ` Sylwester Nawrocki
2016-11-08 15:39 ` Charles Keepax
2016-11-08 16:02 ` Sylwester Nawrocki
2016-11-04 16:14 ` [PATCH RFC 1/7] dma: pl08x: Add support for the DMA slave map Sylwester Nawrocki
2016-11-04 23:26 ` Arnd Bergmann [this message]
2016-11-07 15:41 ` Sylwester Nawrocki
2016-11-07 19:55 ` Arnd Bergmann
2016-11-14 11:51 ` Sylwester Nawrocki
2016-11-04 16:14 ` [PATCH RFC 2/7] ARM: S3C64XX: Add DMA slave maps for PL080 devices Sylwester Nawrocki
2016-11-08 14:44 ` Charles Keepax
2016-11-08 14:55 ` Charles Keepax
2016-11-08 15:53 ` Sylwester Nawrocki
2016-11-10 11:03 ` Charles Keepax
2016-11-10 15:10 ` Sylwester Nawrocki
2016-11-10 15:18 ` Charles Keepax
2016-11-04 16:14 ` [PATCH RFC 3/7] spi: s3c64xx: Do not use platform_data for DMA parameters Sylwester Nawrocki
2016-11-04 17:12 ` Mark Brown
2016-11-07 2:51 ` Andi Shyti
2016-11-04 16:14 ` [PATCH RFC 4/7] ASoC: samsung: i2s: " Sylwester Nawrocki
2016-11-04 17:13 ` Mark Brown
2016-11-04 23:29 ` Arnd Bergmann
2016-11-07 16:02 ` Sylwester Nawrocki
2016-11-07 21:14 ` Arnd Bergmann
2016-11-04 16:14 ` [PATCH RFC 5/7] ASoC: samsung: pcm: " Sylwester Nawrocki
2016-11-04 17:13 ` Mark Brown
2016-11-04 16:14 ` [PATCH RFC 6/7] ARM: S3C64XX: Drop unused DMA fields from struct s3c64xx_spi_csinfo Sylwester Nawrocki
2016-11-04 16:14 ` [PATCH RFC 7/7] ARM: S3C64XX: Drop initialization of unused struct s3c_audio_pdata fields Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201611050026.49560.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox