Subject: [PATCH RFC 2/7] ARM: S3C64XX: Add DMA slave maps for PL080 devices

From: [email-masked] (Charles Keepax)
Date: Tue, 8 Nov 2016 14:55:34 +0000

On Tue, Nov 08, 2016 at 02:44:45PM +0000, Charles Keepax wrote:
> On Fri, Nov 04, 2016 at 05:14:49PM +0100, Sylwester Nawrocki wrote:
> > This patch adds DMA slave map tables to the pl080 devices's
> > platform_data in order to support the new channel request API.
> > A few devices for which there was no DMA support with current
> > code are omitted from the tables.
> > 
> > Signed-off-by: Sylwester Nawrocki <[email-masked]>
> > ---
> >  arch/arm/mach-s3c64xx/pl080.c | 32 ++++++++++++++++++++++++++++++++
> >  1 file changed, 32 insertions(+)
> > 
> > diff --git a/arch/arm/mach-s3c64xx/pl080.c b/arch/arm/mach-s3c64xx/pl080.c
> > index 89c5a62..8c88680 100644
> > --- a/arch/arm/mach-s3c64xx/pl080.c
> > +++ b/arch/arm/mach-s3c64xx/pl080.c
> <snip>
> > @@ -134,6 +153,8 @@ struct pl08x_platform_data s3c64xx_dma0_plat_data = {
> >  	.put_xfer_signal = pl08x_put_xfer_signal,
> >  	.slave_channels = s3c64xx_dma0_info,
> >  	.num_slave_channels = ARRAY_SIZE(s3c64xx_dma0_info),
> > +	.slave_map = s3c64xx_dma0_slave_map,
> > +	.slavecnt = ARRAY_SIZE(s3c64xx_dma0_slave_map),
> >  };
> 
> Here we add a .slavecnt but the pl08x_platform_data structure doesn't
> contain that field. I can't see it on the branch you linked in
> the cover letter either, is it added by a patch on another branch
> I am missing?
> 

Ah I think I see it should be .slave_map_len here.

Thanks,
Charles