From: thomas.petazzoni@free-electrons•com (Thomas Petazzoni)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 09/13] ARM: dts: armada-375: Fixup soc DT warning
Date: Fri, 18 Nov 2016 14:38:35 +0100 [thread overview]
Message-ID: <20161118143835.660cf275@free-electrons.com> (raw)
In-Reply-To: <877f81b013.fsf@free-electrons.com>
Hello,
On Fri, 18 Nov 2016 10:38:32 +0100, Gregory CLEMENT wrote:
> >> > unit address? It doesn't have a 'reg' property if I remember
> >> > correctly.
> >>
> >> But it has a range property.
> >
> > And? There are multiple ranges, and you randomly took the first one for
> > the unit address of the soc node?
>
> Not randomly I followed the same rules that for the regs mentioned in
> the ePAPR paragraph 2.2.1.1:
>
> "The unit-address should match the first address specified in the reg
> property of the node."
But it doesn't say anything about the ranges property. Isn't the dtc
warning in fact over-zealous? The ePAPR says that the unit address
should be the first address of the reg property, but doesn't say
anything about the ranges property.
What I dislike is that there absolutely nothing that forces the ranges
to be written in this order. In another board, it can be written in a
completely different order, which means that the unit address would be
different, which is really silly.
I continue to believe this rule doesn't make sense, and the soc node
shouldn't have a unit address. Maybe Rob or Mark (who is not in Cc, for
some reason?) should say a word about this?
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-11-18 13:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-17 23:08 [PATCH v3 00/13] Various Armada 375 DT warning fixup Gregory CLEMENT
2016-11-17 23:08 ` [PATCH v3 01/13] ARM: dts: armada-375: Add node labels Gregory CLEMENT
2016-11-17 23:08 ` [PATCH v3 02/13] ARM: dts: armada-375: Use the " Gregory CLEMENT
2016-11-17 23:08 ` [PATCH v3 03/13] ARM: dts: armada-375: Fixup mdio DT warning Gregory CLEMENT
2016-11-17 23:08 ` [PATCH v3 04/13] ARM: dts: armada-375: Fixup bootrom " Gregory CLEMENT
2016-11-17 23:08 ` [PATCH v3 05/13] ARM: dts: armada-375: Fixup devbus " Gregory CLEMENT
2016-11-17 23:08 ` [PATCH v3 06/13] ARM: dts: armada-375: Fixup sa-ram " Gregory CLEMENT
2016-11-18 8:59 ` Thomas Petazzoni
2016-11-18 12:06 ` Gregory CLEMENT
2016-11-18 13:35 ` Thomas Petazzoni
2016-11-17 23:08 ` [PATCH v3 07/13] ARM: dts: armada-375: Fixup pcie DT warnings Gregory CLEMENT
2016-11-17 23:08 ` [PATCH v3 08/13] ARM: dts: armada-375: Fixup pinctrl " Gregory CLEMENT
2016-11-17 23:08 ` [PATCH v3 09/13] ARM: dts: armada-375: Fixup soc DT warning Gregory CLEMENT
2016-11-18 8:54 ` Thomas Petazzoni
2016-11-18 9:01 ` Gregory CLEMENT
2016-11-18 9:12 ` Thomas Petazzoni
2016-11-18 9:38 ` Gregory CLEMENT
2016-11-18 13:38 ` Thomas Petazzoni [this message]
2016-11-17 23:08 ` [PATCH v3 10/13] ARM: dts: armada-375: Fixup internal-regs " Gregory CLEMENT
2016-11-17 23:08 ` [PATCH v3 11/13] ARM: dts: armada-375: Remove skeleton.dtsi Gregory CLEMENT
2016-11-17 23:08 ` [PATCH v3 12/13] ARM: dts: armada-375: Fixup memory DT warning Gregory CLEMENT
2016-11-17 23:08 ` [PATCH v3 13/13] ARM: dts: armada-375: Fixup ethernet child " Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161118143835.660cf275@free-electrons.com \
--to=thomas.petazzoni@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox