public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: jason@lakedaemon•net (Jason Cooper)
To: linux-arm-kernel@lists•infradead.org
Subject: ath9k ARMv7 OOPS in v4.8.6, v4.2.8
Date: Thu, 24 Nov 2016 12:28:24 +0000	[thread overview]
Message-ID: <20161124122824.GL2799@io.lakedaemon.net> (raw)
In-Reply-To: <7aba95bdf0d562f3c9640d533c33e1ca@codeaurora.org>

On Thu, Nov 24, 2016 at 02:06:57PM +0800, miaoqing at codeaurora.org wrote:
> 
> >>Okay, so i was 0, so running UP probably isn't going to help.  r7 is
> >>also spec_priv->rfs_chan_spec_scan.
> >>
> >>So, I think the question is... how is this NULL - and has it always
> >>been NULL...
> >
> >The problem appears to be that ath_cmn_process_fft() isn't called that
> >often.  When it is, it crashes in ath_cmn_is_fft_buf_full() because
> >spec_priv->rfs_chan_spec_scan is NULL when ATH9K_DEBUGFS=n. :-(
> >
> >I'm running with ATH9K_DEBUGFS=y now.  If it goes a couple of days
> >without crashing, I'll gin up a patch.
> >
> 
> A similar patch was applied to ath-next branch:
> https://patchwork.kernel.org/patch/9431163/.

Hmm.  Ok, I'm giving it a spin on my board with SMP=y, ATH9K_DEBUGFS=n
(so the only change from known crashing is the patch) and we'll see how
it goes.

Honestly, though, I think the real problem is when kernels are built
without ATH9K_DEBUGFS.  Did the reporter of the crash say if that was
enabled on his system or not?

I'm concerned that there may be other code lurking that secretly depends
on ATH9K_DEBUGFS being enabled.

thx,

Jason.

  reply	other threads:[~2016-11-24 12:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-23 19:15 ath9k ARMv7 OOPS in v4.8.6, v4.2.8 Jason Cooper
2016-11-23 19:26 ` Kalle Valo
2016-11-23 19:34   ` Jason Cooper
2016-11-23 19:51 ` Russell King - ARM Linux
2016-11-23 20:21   ` Jason Cooper
2016-11-23 20:59   ` Jason Cooper
2016-11-23 21:17     ` Russell King - ARM Linux
2016-11-23 21:40       ` Jason Cooper
     [not found]         ` <aaba8b1e30dd4c22be52e50befb202b2@aptaiexm02f.ap.qualcomm.com>
2016-11-24  6:06           ` miaoqing at codeaurora.org
2016-11-24 12:28             ` Jason Cooper [this message]
2016-11-24 12:33         ` Jason Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161124122824.GL2799@io.lakedaemon.net \
    --to=jason@lakedaemon$(echo .)net \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox