From: thomas.petazzoni@free-electrons•com (Thomas Petazzoni)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v6 1/4] i2c: pxa: Add definition of fast and high speed modes via the regs layout
Date: Wed, 30 Nov 2016 16:49:38 +0100 [thread overview]
Message-ID: <20161130164938.32ba768f@free-electrons.com> (raw)
In-Reply-To: <20161130140017.26307-2-romain.perier@free-electrons.com>
Hello,
On Wed, 30 Nov 2016 15:00:14 +0100, Romain Perier wrote:
> #ifdef CONFIG_I2C_PXA_SLAVE
> dev_info(&i2c->adap.dev, "Enabling slave mode\n");
> @@ -1234,6 +1238,9 @@ static int i2c_pxa_probe(struct platform_device *dev)
> i2c->reg_idbr = i2c->reg_base + pxa_reg_layout[i2c_type].idbr;
> i2c->reg_icr = i2c->reg_base + pxa_reg_layout[i2c_type].icr;
> i2c->reg_isr = i2c->reg_base + pxa_reg_layout[i2c_type].isr;
> + i2c->fm_mask = pxa_reg_layout[i2c_type].fm ? pxa_reg_layout[i2c_type].fm : ICR_FM;
> + i2c->hs_mask = pxa_reg_layout[i2c_type].hs ? pxa_reg_layout[i2c_type].hs : ICR_HS;
These lines are too long according to checkpatch. What about using what
Wolfram originally suggested, i.e:
i2c->fm_mask = pxa_reg_layout[i2c_type].fm ?: ICR_FM;
which does exactly the same, but fits within 80 characters ?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-11-30 15:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-30 14:00 [PATCH v6 0/4] Add basic support for the I2C units of the Armada 3700 Romain Perier
2016-11-30 14:00 ` [PATCH v6 1/4] i2c: pxa: Add definition of fast and high speed modes via the regs layout Romain Perier
2016-11-30 15:49 ` Thomas Petazzoni [this message]
2016-11-30 14:00 ` [PATCH v6 2/4] i2c: pxa: Add support for the I2C units found in Armada 3700 Romain Perier
2016-11-30 15:43 ` Gregory CLEMENT
2016-11-30 14:00 ` [PATCH v6 3/4] arm64: dts: marvell: Add I2C definitions for the " Romain Perier
2016-11-30 14:00 ` [PATCH v6 4/4] dt-bindings: i2c: pxa: Update the documentation " Romain Perier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161130164938.32ba768f@free-electrons.com \
--to=thomas.petazzoni@free-electrons$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox