From: andrew@lunn•ch (Andrew Lunn)
To: linux-arm-kernel@lists•infradead.org
Subject: [v4, 3/3] ARM: dts: vf610-zii-dev-rev-b: Remove 'fixed-link' from DSA ports
Date: Wed, 21 Dec 2016 16:22:30 +0100 [thread overview]
Message-ID: <20161221152230.GK30952@lunn.ch> (raw)
In-Reply-To: <20161221132519.bkkqyfk3beow7nc5@pengutronix.de>
On Wed, Dec 21, 2016 at 02:25:19PM +0100, Uwe Kleine-K?nig wrote:
> On Wed, Dec 21, 2016 at 03:58:45PM +0300, Nikita Yushchenko wrote:
> > > Remove 'fixed-link' nodes from DSA ports since they are not needed (they
> > > are not limiting link's speed and the ports will be configured to their
> > > maximux speed as a default)
> > >
> > > Suggested-by: Andrew Lunn <andrew@lunn•ch>
> > > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail•com>
> >
> > With this patch, ports connected to revB's second switch stop working.
>
> This is probably because without a fixed-link node the phy-mode setting
> isn't applied by the driver.
Yep, bad suggestion from me. If the phy-mode was not needed, then you
can drop the fixed-link. With the phy-mode, you also need the fixed
link.
Sorry for the wasted time,
Andrew
next prev parent reply other threads:[~2016-12-21 15:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-19 7:17 [PATCH v4 1/3] ARM: dts: vf610-zii-dev-rev-b: Remove leftover PWM pingroup Andrey Smirnov
2016-12-19 7:17 ` [PATCH v4 2/3] ARM: dts: vf610-zii-dev: Add .dts file for rev. C Andrey Smirnov
2016-12-30 1:58 ` Shawn Guo
2016-12-19 7:17 ` [PATCH v4 3/3] ARM: dts: vf610-zii-dev-rev-b: Remove 'fixed-link' from DSA ports Andrey Smirnov
2016-12-21 12:58 ` [v4, " Nikita Yushchenko
2016-12-21 13:25 ` Uwe Kleine-König
2016-12-21 15:22 ` Andrew Lunn [this message]
2016-12-21 13:30 ` [v4, 1/3] ARM: dts: vf610-zii-dev-rev-b: Remove leftover PWM pingroup Nikita Yushchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161221152230.GK30952@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox