public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: andy.gross@linaro•org (Andy Gross)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/5] ARM: dts: qcom: apq8064: Add missing scm clock
Date: Fri, 6 Jan 2017 21:01:20 -0600	[thread overview]
Message-ID: <20170107030120.GC5710@hector.attlocal.net> (raw)
In-Reply-To: <CALAqxLVGMzPmRBM5SPO=pQjuasf0f_aRJ+94FUHtidYYU7yhpA@mail.gmail.com>

On Fri, Jan 06, 2017 at 05:10:44PM -0800, John Stultz wrote:
> On Wed, Dec 21, 2016 at 3:49 AM, Bjorn Andersson
> <bjorn.andersson@linaro•org> wrote:
> > As per the device tree binding the apq8064 scm node requires the core
> > clock to be specified, so add this.
> >
> > Cc: John Stultz <john.stultz@linaro•org>
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro•org>
> > ---
> >  arch/arm/boot/dts/qcom-apq8064.dtsi | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/qcom-apq8064.dtsi b/arch/arm/boot/dts/qcom-apq8064.dtsi
> > index 268bd470c865..78bf155a52f3 100644
> > --- a/arch/arm/boot/dts/qcom-apq8064.dtsi
> > +++ b/arch/arm/boot/dts/qcom-apq8064.dtsi
> > @@ -303,6 +303,9 @@
> >         firmware {
> >                 scm {
> >                         compatible = "qcom,scm-apq8064";
> > +
> > +                       clocks = <&gcc CE3_CORE_CLK>;
> > +                       clock-names = "core";
> 
> 
> Tested-by: John Stultz <john.stultz@linaro•org>
> 
> I know Bjorn has a new version of this patch that uses the
> RPM_DAYTONA_FABRIC_CLK value, but that one results in problems with
> usb gadget functionality on my Nexus7.  This one seems to work ok
> though.

Odd.  Is the usb gadget using the daytona but not getting a reference?  I wonder
if this is related to not having the bus driver running the bus clk enablement
and frequencies.


Andy

  reply	other threads:[~2017-01-07  3:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-21 11:49 [PATCH 1/5] ARM: dts: qcom: apq8064: Add missing scm clock Bjorn Andersson
2016-12-21 11:49 ` [PATCH 2/5] ARM: dts: qcom: apq8064: Add riva-pil node Bjorn Andersson
2017-01-07  1:07   ` John Stultz
2016-12-21 11:49 ` [PATCH 3/5] ARM: dts: qcom: apq8064-sony-yuga: Enable riva-pil Bjorn Andersson
2016-12-21 11:49 ` [PATCH 4/5] ARM: dts: qcom: sd600-eval: pm8921_s2 regulator properties Bjorn Andersson
2016-12-21 11:49 ` [PATCH 5/5] ARM: dts: qcom: sd600eval: Enable riva-pil Bjorn Andersson
2016-12-29  3:14 ` [1/5] ARM: dts: qcom: apq8064: Add missing scm clock Andy Gross
2017-01-07  1:10 ` [PATCH 1/5] " John Stultz
2017-01-07  3:01   ` Andy Gross [this message]
2017-01-07  7:30     ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170107030120.GC5710@hector.attlocal.net \
    --to=andy.gross@linaro$(echo .)org \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox