From: mhiramat@kernel•org (Masami Hiramatsu)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 2/2 v2] perf tools: Enable bpf prologue for arm64
Date: Thu, 26 Jan 2017 10:49:16 +0900 [thread overview]
Message-ID: <20170126104916.971478fa29083cf4ae14fac3@kernel.org> (raw)
In-Reply-To: <20170125133201.GC27026@arm.com>
On Wed, 25 Jan 2017 13:32:01 +0000
Will Deacon <will.deacon@arm•com> wrote:
> On Wed, Jan 25, 2017 at 07:23:11AM +0000, He Kuang wrote:
> > Since HAVE_KPROBES can be enabled in arm64, this patch introduces
> > regs_query_register_offset() to convert register name to offset for
> > arm64, so the BPF prologue feature is ready to use.
> >
> > This patch also changes the 'dwarfnum' to 'offset' in register table,
> > so the related functions are consistent with x86.
>
> Wouldn't it be an awful lot simpler just to leave the code as-is, and
> implement regs_query_register_offset in the same way that we implement
> get_arch_regstr but return the dwarfnum?
No, since the offset is not same as dwarfnum.
With this style, the index of array becomes the dwarfnum (the index of
each register defined by DWARF) and the "offset" member means the
byte-offset of the register in (user_)pt_regs. Those should be different.
> I don't really see the point of all the refactoring.
Also, from the maintenance point of view, this rewrite work makes
the code simply similar to x86 implementation, that will be easier to
maintain :)
Thank you,
--
Masami Hiramatsu <mhiramat@kernel•org>
next prev parent reply other threads:[~2017-01-26 1:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20170124190908.GG10340@kernel.org>
2017-01-25 7:23 ` [PATCH 2/2 v2] perf tools: Enable bpf prologue for arm64 He Kuang
2017-01-25 13:32 ` Will Deacon
2017-01-26 1:49 ` Masami Hiramatsu [this message]
2017-01-26 16:52 ` Will Deacon
2017-01-26 19:31 ` Arnaldo Carvalho de Melo
2017-02-03 11:08 ` Hekuang
2017-01-26 1:51 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170126104916.971478fa29083cf4ae14fac3@kernel.org \
--to=mhiramat@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox