From: chunyan.zhang@spreadtrum•com (Chunyan Zhang)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 4/5] sprd_serial: switch comptible string to sc-uart
Date: Fri, 17 Feb 2017 15:35:11 +0800 [thread overview]
Message-ID: <20170217073511.GB8767@spreadtrum.com> (raw)
In-Reply-To: <1761969.45NG6Q1Iyc@wuerfel>
On ?, 2? 16, 2017 at 02:31:38?? +0100, Arnd Bergmann wrote:
> On Tuesday, February 14, 2017 5:19:11 PM CET Chunyan Zhang wrote:
> > static const struct of_device_id serial_ids[] = {
> > - {.compatible = "sprd,sc9836-uart",},
> > + {.compatible = "sprd,sc-uart",},
> > {}
>
> We really need this to be specific, in case Spreadtrum ever
> makes a slightly different UART that is not 100% compatible
> with this one. Also, you can't remove the string you already have,
> only add to it.
>
> Normally when you have a new chip that is compatible with one
> we already have a driver for, we mark the device as compatible
> with the old one and avoid having to change the driver, e.g.
>
> compatible = "sprd,sc9995-uart", "sprd,sc9836-uart";
>
> This way, the driver could later be changed to handle anything
> that is compatible with sc9995 differently from sc9836, but
> by default it would match the original string.
>
Right, I've addressed this when I received the same comments from
Rob Herring :)
Thanks for your comments,
Chunyan
> Arnd
next prev parent reply other threads:[~2017-02-17 7:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 9:19 [PATCH 0/5] Add Spreadtrum SP9860G support Chunyan Zhang
2017-02-14 9:19 ` [PATCH 1/5] arm64: dts: Add basic DT to support Spreadtrum's SP9860G Chunyan Zhang
2017-02-14 15:57 ` Mark Rutland
2017-02-16 7:57 ` Chunyan Zhang
2017-02-14 16:44 ` Sudeep Holla
2017-02-17 7:28 ` Chunyan Zhang
2017-02-17 10:28 ` Sudeep Holla
2017-02-20 9:37 ` Chunyan Zhang
2017-02-20 10:47 ` Sudeep Holla
2017-02-20 12:56 ` Chunyan Zhang
2017-02-14 9:19 ` [PATCH 2/5] Documentation: sprd: Add bindings for SP9860G Chunyan Zhang
2017-02-14 9:19 ` [PATCH 3/5] devicetree: bindings: revise compatible string of sprd uart Chunyan Zhang
2017-02-14 17:02 ` Rob Herring
2017-02-14 9:19 ` [PATCH 4/5] sprd_serial: switch comptible string to sc-uart Chunyan Zhang
2017-02-16 13:31 ` Arnd Bergmann
2017-02-17 7:35 ` Chunyan Zhang [this message]
2017-02-14 9:19 ` [PATCH 5/5] serial: sprd: adjust TIMEOUT to a big value Chunyan Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170217073511.GB8767@spreadtrum.com \
--to=chunyan.zhang@spreadtrum$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox