From: thierry.reding@gmail•com (Thierry Reding)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 3/5] soc/tegra: Move Tegra flowctrl driver
Date: Mon, 20 Mar 2017 18:00:40 +0100 [thread overview]
Message-ID: <20170320170040.GC14787@ulmo.ba.sec> (raw)
In-Reply-To: <c0b18931-1377-813d-c8a3-60aea4379aa6@nvidia.com>
On Mon, Mar 20, 2017 at 04:37:58PM +0000, Jon Hunter wrote:
>
>
> On 20/03/17 14:14, Thierry Reding wrote:
> > * PGP Signed by an unknown key
> >
> > On Wed, Mar 15, 2017 at 01:31:53PM +0000, Jon Hunter wrote:
> > [...]
> >> +static int __init tegra_flowctrl_init(void)
> >> +{
> >> + /* hardcoded fallback if device tree node is missing */
> >> + unsigned long base = 0x60007000;
> >> + unsigned long size = SZ_4K;
> >> + struct device_node *np;
> >> +
> >> + if (!soc_is_tegra())
> >> + return 0;
> >> +
> >> + np = of_find_matching_node(NULL, matches);
> >> + if (np) {
> >> + struct resource res;
> >> +
> >> + if (of_address_to_resource(np, 0, &res) == 0) {
> >> + size = resource_size(&res);
> >> + base = res.start;
> >> + }
> >> +
> >> + of_node_put(np);
> >> + }
> >> +
> >> + tegra_flowctrl_base = ioremap_nocache(base, size);
> >> +
> >> + if (!tegra_flowctrl_base)
> >> + return -ENXIO;
> >> +
> >> + return 0;
> >> +}
> >> +early_initcall(tegra_flowctrl_init);
> >
> > Do we want to implement a hand-off to a proper driver at some point,
> > similar to what we have for PMC?
>
> Yes I can add, it won't do much apart from remap the io-space, but at
> least it is registered as a device then.
Yeah, the same is true for PMC, but I find it quite convenient to have a
struct device * around. Ideally, of course, we'd be able to somehow have
deferred probe take care of the dependencies so that we wouldn't have to
muck about with these initcalls, but I don't think we're there yet. That
"partial" driver would at least be some way in the right direction.
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170320/182906aa/attachment.sig>
next prev parent reply other threads:[~2017-03-20 17:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-15 13:31 [PATCH 0/5] soc/tegra: Enable flowctrl support for Tegra132/210 Jon Hunter
2017-03-15 13:31 ` [PATCH 1/5] ARM: tegra: WARN if flowctrl is not supported Jon Hunter
2017-03-20 14:10 ` Thierry Reding
2017-03-20 16:32 ` Jon Hunter
2017-03-15 13:31 ` [PATCH 2/5] ARM: tegra: Remove unnecessary inclusion of flowctrl header Jon Hunter
2017-03-15 13:31 ` [PATCH 3/5] soc/tegra: Move Tegra flowctrl driver Jon Hunter
2017-03-20 14:14 ` Thierry Reding
2017-03-20 16:37 ` Jon Hunter
2017-03-20 17:00 ` Thierry Reding [this message]
2017-03-15 13:31 ` [PATCH 4/5] dt-bindings: tegra: Update compatible strings for Tegra flowctrl Jon Hunter
2017-03-20 14:32 ` Thierry Reding
2017-03-15 13:31 ` [PATCH 5/5] soc/tegra: Add initial flowctrl support for Tegra210 Jon Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170320170040.GC14787@ulmo.ba.sec \
--to=thierry.reding@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox