From: will.deacon@arm•com (Will Deacon)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v2 4/5] iommu/arm-smmu-v3: Install bypass STEs for IOMMU_DOMAIN_IDENTITY domains
Date: Tue, 21 Mar 2017 17:08:16 +0000 [thread overview]
Message-ID: <20170321170816.GE30948@arm.com> (raw)
In-Reply-To: <7d39363e-90e8-4119-3b7e-b1c4f6250879@arm.com>
Hi Robin,
On Thu, Mar 16, 2017 at 06:19:48PM +0000, Robin Murphy wrote:
> On 16/03/17 16:24, Nate Watterson wrote:
> > On 2017-03-10 15:49, Will Deacon wrote:
> >> In preparation for allowing the default domain type to be overridden,
> >> this patch adds support for IOMMU_DOMAIN_IDENTITY domains to the
> >> ARM SMMUv3 driver.
> >>
> >> An identity domain is created by placing the corresponding stream table
> >> entries into "bypass" mode, which allows transactions to flow through
> >> the SMMU without any translation.
> >>
> >
> > What about masters that require SMMU intervention to override their
> > native memory attributes to make them consistent with the CCA (acpi)
> > or dma-coherent (dt) values specified in FW?
>
> Well, we've already broken them ;) My interpretation of "dma-coherent"
> is as the equivalent of DACS=1,CPM=1, i.e. not dependent on SMMU
> override. For the CCA=1,DACS=0 case (I'm going to pretend the DT
> equivalent will never exist...) the first problem to solve is how to
> inherit the appropriate configuration from the firmware, because right
> now we're not even pretending to support that.
Indeed, and that would need to be added as a separate patch series when
the need arises.
> >> /* Nuke the existing STE_0 value, as we're going to rewrite it */
> >> - val = ste->valid ? STRTAB_STE_0_V : 0;
> >> + val = STRTAB_STE_0_V;
> >> +
> >> + /* Bypass/fault */
> >> + if (!ste->assigned || !(ste->s1_cfg || ste->s2_cfg)) {
> >> + if (!ste->assigned && disable_bypass)
>
> ...yuck. After about 5 minutes of staring at that, I've convinced myself
> that it would make much more sense to always clear the strtab_ent
> configs on detach, such that you never need the outer !ste->assigned
> check here...
I was deliberately keeping the strtab_ent intact in case we ever grow
support for nested translation, where we might well want to detach a
stage 1 but keep the stage 2 installed. I don't think the code is that
bad, so I'd like to leave it like it is for now.
Will
next prev parent reply other threads:[~2017-03-21 17:08 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-10 20:49 [PATCH v2 0/5] Implement SMMU passthrough using the default domain Will Deacon
2017-03-10 20:49 ` [PATCH v2 1/5] iommu/arm-smmu: Restrict domain attributes to UNMANAGED domains Will Deacon
2017-03-10 20:49 ` [PATCH v2 2/5] iommu/arm-smmu: Install bypass S2CRs for IOMMU_DOMAIN_IDENTITY domains Will Deacon
2017-03-10 20:49 ` [PATCH v2 3/5] iommu/arm-smmu-v3: Make arm_smmu_install_ste_for_dev return void Will Deacon
2017-03-16 16:55 ` Nate Watterson
2017-03-10 20:49 ` [PATCH v2 4/5] iommu/arm-smmu-v3: Install bypass STEs for IOMMU_DOMAIN_IDENTITY domains Will Deacon
2017-03-16 16:24 ` Nate Watterson
2017-03-16 18:19 ` Robin Murphy
2017-03-21 17:08 ` Will Deacon [this message]
2017-03-21 17:33 ` Robin Murphy
2017-03-10 20:49 ` [PATCH v2 5/5] iommu: Allow default domain type to be set on the kernel command line Will Deacon
2017-03-21 15:45 ` Joerg Roedel
2017-03-21 17:21 ` Will Deacon
2017-03-21 17:46 ` Robin Murphy
2017-03-21 18:17 ` Will Deacon
2017-03-23 10:22 ` Sricharan R
2017-03-23 10:38 ` Sricharan R
2017-03-22 11:25 ` Joerg Roedel
2017-03-21 15:46 ` [PATCH v2 0/5] Implement SMMU passthrough using the default domain Joerg Roedel
2017-03-21 16:42 ` Will Deacon
2017-03-21 16:46 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170321170816.GE30948@arm.com \
--to=will.deacon@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox