From: computersforpeace@gmail•com (Brian Norris)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 1/9] mtd: sharpslpart: add sharpslpart MTD partition parser
Date: Thu, 8 Jun 2017 18:42:40 -0700 [thread overview]
Message-ID: <20170609014240.GM102137@google.com> (raw)
In-Reply-To: <1496270458-6479-2-git-send-email-andrea.adami@gmail.com>
Oh, one more thing:
On Thu, Jun 01, 2017 at 12:40:50AM +0200, Andrea Adami wrote:
> diff --git a/drivers/mtd/sharpslpart.c b/drivers/mtd/sharpslpart.c
> new file mode 100644
> index 0000000..40aebe9
> --- /dev/null
> +++ b/drivers/mtd/sharpslpart.c
> @@ -0,0 +1,132 @@
> +/*
> + * MTD partition parser for NAND flash on Sharp SL Series
> + *
> + * Copyright (C) 2017 Andrea Adami <andrea.adami@gmail•com>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + *
> + */
> +
> +#include <linux/kernel.h>
> +#include <linux/slab.h>
> +#include <linux/module.h>
> +#include <linux/mtd/mtd.h>
> +#include <linux/mtd/partitions.h>
> +#include "sharpsl_ftl.h"
> +
> +/* factory defaults */
> +#define SHARPSL_NAND_PARTS 3
> +#define SHARPSL_FTL_PARTITION_SIZE (7 * 1024 * 1024)
> +#define PARAM_BLOCK_PARTITIONINFO1 0x00060000
> +#define PARAM_BLOCK_PARTITIONINFO2 0x00064000
> +
> +#define BOOT_MAGIC be32_to_cpu(0x424f4f54) /* BOOT */
> +#define FSRO_MAGIC be32_to_cpu(0x4653524f) /* FSRO */
> +#define FSRW_MAGIC be32_to_cpu(0x46535257) /* FSRW */
[...]
> +struct sharpsl_nand_partitioninfo {
> + u32 start;
> + u32 end;
I was going to ignore this earlier, but I just noticed that you handle
endianness for the magic values above, so...
shouldn't you handle endianness for the start and end fields too?
> + u32 magic;
> + u32 reserved;
> +};
[...]
Brian
next prev parent reply other threads:[~2017-06-09 1:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-31 22:40 [PATCH v3 0/9] mtd: sharpslpart partition parser Andrea Adami
2017-05-31 22:40 ` [PATCH v3 1/9] mtd: sharpslpart: add sharpslpart MTD " Andrea Adami
2017-06-09 1:30 ` Brian Norris
2017-06-20 8:52 ` Andrea Adami
2017-06-20 22:05 ` Brian Norris
2017-06-09 1:42 ` Brian Norris [this message]
2017-06-20 8:56 ` Andrea Adami
2017-05-31 22:40 ` [PATCH v3 2/9] mtd: nand: sharpsl.h: support partition parser types Andrea Adami
2017-05-31 22:40 ` [PATCH v3 3/9] mfd: tmio.h: " Andrea Adami
2017-06-01 8:40 ` Wolfram Sang
2017-06-01 14:35 ` Lee Jones
2017-06-03 21:40 ` Andrea Adami
2017-06-05 7:59 ` Lee Jones
2017-05-31 22:40 ` [PATCH v3 4/9] mtd: nand: sharpsl.c: take in account " Andrea Adami
2017-06-01 8:35 ` Wolfram Sang
2017-05-31 22:40 ` [PATCH v3 5/9] mtd: nand: tmio_nand.c: " Andrea Adami
2017-06-01 8:37 ` Wolfram Sang
2017-05-31 22:40 ` [PATCH v3 6/9] arm: pxa: corgi.c: remove hardcoded partitioning, use sharpslpart parser Andrea Adami
2017-05-31 22:40 ` [PATCH v3 7/9] arm: pxa: tosa.c: " Andrea Adami
2017-05-31 22:40 ` [PATCH v3 8/9] arm: pxa: spitz.c: " Andrea Adami
2017-05-31 22:40 ` [PATCH v3 9/9] arm: pxa: poodle.c: " Andrea Adami
2017-06-09 1:35 ` [PATCH v3 0/9] mtd: sharpslpart partition parser Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170609014240.GM102137@google.com \
--to=computersforpeace@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox