From: will.deacon@arm•com (Will Deacon)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] arm64: Decode information from ESR upon mem faults
Date: Mon, 19 Jun 2017 18:13:05 +0100 [thread overview]
Message-ID: <20170619171305.GA12786@arm.com> (raw)
In-Reply-To: <1497446043-50944-1-git-send-email-julien.thierry@arm.com>
On Wed, Jun 14, 2017 at 02:14:03PM +0100, Julien Thierry wrote:
> When receiving unhandled faults from the CPU, description is very sparse.
> Adding information about faults decoded from ESR.
>
> Added defines to esr.h corresponding ESR fields. Values are based on ARM
> Archtecture Reference Manual (DDI 0487B.a), section D7.2.28 ESR_ELx, Exception
> Syndrome Register (ELx) (pages D7-2275 to D7-2280).
>
> New output is of the form:
> [ 122.109118] Mem abort info:
> [ 122.111884] Exception class = DABT (current EL)
> [ 122.116564] IL = 32 bits
> [ 122.119242] SET = 0
> [ 122.121507] FnV = 0
> [ 122.123754] EA = 0
> [ 122.125928] S1PTW = 0
> [ 122.128347] Data abort info:
> [ 122.131212] ISS[23:14] invalid
Is it still worth printing the ISS value here? I'm wondering about the
case where an old kernel runs on a new CPU and gets an abort that was
previously undefined.
> [ 122.134417] CM = 0
> [ 122.136589] WnR = 1
Hmm, this might get really confusing if multiple CPUs end up with their
prints interleaved. Perhaps having a print_unhandled_fault_info helper that
takes a prefix string (e.g. "Unhandled fault") and constructs the
information on one line would be preferable?
Then again, you could make the same argument about multi-line register
dumps, so perhaps I'm worrying too much here. Thoughts?
Will
next prev parent reply other threads:[~2017-06-19 17:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 13:14 [PATCH] arm64: Decode information from ESR upon mem faults Julien Thierry
2017-06-19 17:13 ` Will Deacon [this message]
2017-06-29 8:58 ` Julien Thierry
2017-07-11 17:57 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170619171305.GA12786@arm.com \
--to=will.deacon@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox