From: mchehab@s-opensource•com (Mauro Carvalho Chehab)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] media: Convert to using %pOF instead of full_name
Date: Thu, 20 Jul 2017 08:15:38 -0300 [thread overview]
Message-ID: <20170720081508.33563afe@vento.lan> (raw)
In-Reply-To: <CAL_JsqLDCgO60ECGB70pMNcaLg0zUcJ6_+50vH-evfGe-D266Q@mail.gmail.com>
Em Wed, 19 Jul 2017 11:02:01 -0500
Rob Herring <robh@kernel•org> escreveu:
> On Wed, Jul 19, 2017 at 4:41 AM, Sylwester Nawrocki
> <s.nawrocki@samsung•com> wrote:
> > On 07/18/2017 11:43 PM, Rob Herring wrote:
> >> Now that we have a custom printf format specifier, convert users of
> >> full_name to use %pOF instead. This is preparation to remove storing
> >> of the full path string for each node.
> >>
> >> Signed-off-by: Rob Herring <robh@kernel•org>
> >
> >> ---
> >> drivers/media/i2c/s5c73m3/s5c73m3-core.c | 3 +-
> >> drivers/media/i2c/s5k5baf.c | 7 ++--
> >> drivers/media/platform/am437x/am437x-vpfe.c | 4 +-
> >> drivers/media/platform/atmel/atmel-isc.c | 4 +-
> >> drivers/media/platform/davinci/vpif_capture.c | 16 ++++----
> >> drivers/media/platform/exynos4-is/fimc-is.c | 8 ++--
> >> drivers/media/platform/exynos4-is/fimc-lite.c | 3 +-
> >> drivers/media/platform/exynos4-is/media-dev.c | 8 ++--
> >> drivers/media/platform/exynos4-is/mipi-csis.c | 4 +-
> >> drivers/media/platform/mtk-mdp/mtk_mdp_comp.c | 6 +--
> >> drivers/media/platform/mtk-mdp/mtk_mdp_core.c | 8 ++--
> >> drivers/media/platform/omap3isp/isp.c | 8 ++--
> >> drivers/media/platform/pxa_camera.c | 2 +-
> >> drivers/media/platform/rcar-vin/rcar-core.c | 4 +-
> >> drivers/media/platform/soc_camera/soc_camera.c | 6 +--
> >> drivers/media/platform/xilinx/xilinx-vipp.c | 52 +++++++++++++-------------
> >> drivers/media/v4l2-core/v4l2-async.c | 4 +-
> >> drivers/media/v4l2-core/v4l2-clk.c | 3 +-
> >> include/media/v4l2-clk.h | 4 +-
> >> 19 files changed, 71 insertions(+), 83 deletions(-)
> >
> >> diff --git a/drivers/media/platform/xilinx/xilinx-vipp.c b/drivers/media/platform/xilinx/xilinx-vipp.c
> >> index ac4704388920..9233ad0b1b6b 100644
> >> --- a/drivers/media/platform/xilinx/xilinx-vipp.c
> >> +++ b/drivers/media/platform/xilinx/xilinx-vipp.c
> >
> >> @@ -144,9 +144,8 @@ static int xvip_graph_build_one(struct xvip_composite_device *xdev,
> >> remote = ent->entity;
> >>
> >> if (link.remote_port >= remote->num_pads) {
> >> - dev_err(xdev->dev, "invalid port number %u on %s\n",
> >> - link.remote_port,
> >> - to_of_node(link.remote_node)->full_name);
> >> + dev_err(xdev->dev, "invalid port number %u on %pOF\n",
> >> + link.remote_port, link.remote_node);
> >
> > Shouldn't there be to_of_node(link.remote_node) instead of link.remote_node ?
>
> Humm, yes. I thought I fixed that.
After such fix, I'm OK with this patch.
Are you planning to apply it on your tree, or via the media one?
I guess it is probably better to apply via media, in order to avoid
conflicts with other changes.
Thanks,
Mauro
next prev parent reply other threads:[~2017-07-20 11:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170718215328epcas2p2e5e1d7df96fcd894e70a961df864abdd@epcas2p2.samsung.com>
2017-07-18 21:43 ` [PATCH] media: Convert to using %pOF instead of full_name Rob Herring
2017-07-19 8:28 ` Niklas Söderlund
2017-07-19 8:55 ` Laurent Pinchart
2017-07-19 9:41 ` Sylwester Nawrocki
2017-07-19 16:02 ` Rob Herring
2017-07-19 21:05 ` Frank Rowand
2017-07-20 10:22 ` Sylwester Nawrocki
2017-07-20 11:15 ` Mauro Carvalho Chehab [this message]
2017-07-20 14:06 ` Rob Herring
2017-07-19 10:26 ` Matthias Brugger
2017-07-19 11:39 ` Nicolas Ferre
2017-07-20 11:21 ` Lad, Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170720081508.33563afe@vento.lan \
--to=mchehab@s-opensource$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox