From: greg@kroah•com (Greg KH)
To: linux-arm-kernel@lists•infradead.org
Subject: [[PATCH]] Revert "leds: handle suspend/resume in heartbeat trigger"
Date: Sun, 27 Aug 2017 14:46:36 +0200 [thread overview]
Message-ID: <20170827124636.GA2038@kroah.com> (raw)
In-Reply-To: <CAMuHMdXm_WQh8-krQgT2+nfr3xTuDvnHbK3B+qJJaeVsvRu5gw@mail.gmail.com>
On Fri, Aug 25, 2017 at 10:23:11AM +0200, Geert Uytterhoeven wrote:
> On Wed, Aug 23, 2017 at 9:34 PM, Pavel Machek <pavel@ucw•cz> wrote:
> >> On Tue, Jun 13, 2017 at 4:39 AM, Zhang Bo <bo.zhang@nxp•com> wrote:
> >> > This reverts commit 5ab92a7cb82c66bf30685583a38a18538e3807db.
> >> >
> >> > System cannot enter suspend mode because of heartbeat led trigger.
> >> > In autosleep_wq, try_to_suspend function will try to enter suspend
> >> > mode in specific period. it will get wakeup_count then call pm_notifier
> >> > chain callback function and freeze processes.
> >> > Heartbeat_pm_notifier is called and it call led_trigger_unregister to
> >> > change the trigger of led device to none. It will send uevent message
> >> > and the wakeup source count changed. As wakeup_count changed, suspend
> >> > will abort.
> >> >
> >> > Signed-off-by: Zhang Bo <bo.zhang@nxp•com>
> >>
> >> While investigating an heartbeat LED issue in v4.9.40-ltsi, I stumpled on this
> >> revert (commit 436c4c45b5b9562b ("Revert "leds: handle suspend/resume in
> >> heartbeat trigger"") in v4.12-rc6), which was not backported to v4.9 (yet).
> >>
> >> Interestingly, while running v4.9.x on r8a7791/koelsch with an LED configured
> >> for heartbeat, I can actually suspend the system using s2ram.
> >> However, after system resume the heartbeat LED no longer flashes.
> >> /sys/class/leds/LED6/trigger shows the trigger is still "none", and thus
> >> wasn't restored to "heartbeat" by the notifier.
> >> There's no "could not re-register heartbeat trigger" message printed.
> >>
> >> Backporting the revert fixes this.
> >
> > You have my Acked-by: if you want to submit this to some -stable
> > kernels...
>
> Thank you!
>
> Greg: Can you please queue 436c4c45b5b9562b ("Revert "leds: handle
> suspend/resume in heartbeat trigger"") for v4.9.x or v4.9-ltsi?
> Thanks!
Now applied, thanks.
greg k-h
prev parent reply other threads:[~2017-08-27 12:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-13 2:39 [[PATCH]] Revert "leds: handle suspend/resume in heartbeat trigger" Zhang Bo
2017-06-13 7:31 ` Pavel Machek
2017-06-13 9:35 ` Linus Walleij
2017-07-13 12:03 ` Pavel Machek
2017-07-13 12:46 ` Linus Walleij
2017-06-13 18:44 ` Jacek Anaszewski
2017-08-23 14:02 ` Geert Uytterhoeven
2017-08-23 19:34 ` Pavel Machek
2017-08-25 8:23 ` Geert Uytterhoeven
2017-08-27 12:46 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170827124636.GA2038@kroah.com \
--to=greg@kroah$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox