From: will.deacon@arm•com (Will Deacon)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH v3 1/2] arm_arch_timer: Expose event stream status
Date: Thu, 12 Oct 2017 11:26:12 +0100 [thread overview]
Message-ID: <20171012102612.GB7395@arm.com> (raw)
In-Reply-To: <e94ecbdc-47ae-7351-e422-1fa426e35fad@arm.com>
On Thu, Oct 12, 2017 at 10:40:57AM +0100, Julien Thierry wrote:
>
>
> On 12/10/17 10:30, Will Deacon wrote:
> >On Thu, Oct 12, 2017 at 10:27:06AM +0100, Suzuki K Poulose wrote:
> >>On 29/09/17 11:52, Julien Thierry wrote:
> >>>The arch timer configuration for a CPU might get reset after suspending
> >>>said CPU.
> >>>
> >>>In order to reliably use the event stream in the kernel (e.g. for delays),
> >>>we keep track of the state where we can safely concider the event stream as
> >>
> >>nit: consider
> >>
> >>>properly configured.
> >>>
> >>>Signed-off-by: Julien Thierry <julien.thierry@arm•com>
> >>>Cc: Mark Rutland <mark.rutland@arm•com>
> >>>Cc: Marc Zyngier <marc.zyngier@arm•com>
> >>>Cc: Russell King <linux@armlinux•org.uk>
> >>>Cc: Catalin Marinas <catalin.marinas@arm•com>
> >>>Cc: Will Deacon <will.deacon@arm•com>
> >>>---
> >>> arch/arm/include/asm/arch_timer.h | 1 +
> >>> arch/arm64/include/asm/arch_timer.h | 1 +
> >>> drivers/clocksource/arm_arch_timer.c | 20 ++++++++++++++++++--
> >>> include/clocksource/arm_arch_timer.h | 6 ++++++
> >>> 4 files changed, 26 insertions(+), 2 deletions(-)
> >>>
> >>>diff --git a/arch/arm/include/asm/arch_timer.h b/arch/arm/include/asm/arch_timer.h
> >>>index d4ebf56..0b6e104 100644
> >>>--- a/arch/arm/include/asm/arch_timer.h
> >>>+++ b/arch/arm/include/asm/arch_timer.h
> >>>@@ -106,6 +106,7 @@ static inline u32 arch_timer_get_cntkctl(void)
> >>> static inline void arch_timer_set_cntkctl(u32 cntkctl)
> >>> {
> >>> asm volatile("mcr p15, 0, %0, c14, c1, 0" : : "r" (cntkctl));
> >>>+ isb();
> >>> }
> >>>
> >>> #endif
> >>>diff --git a/arch/arm64/include/asm/arch_timer.h b/arch/arm64/include/asm/arch_timer.h
> >>>index a652ce0..bdedd8f 100644
> >>>--- a/arch/arm64/include/asm/arch_timer.h
> >>>+++ b/arch/arm64/include/asm/arch_timer.h
> >>>@@ -144,6 +144,7 @@ static inline u32 arch_timer_get_cntkctl(void)
> >>> static inline void arch_timer_set_cntkctl(u32 cntkctl)
> >>> {
> >>> write_sysreg(cntkctl, cntkctl_el1);
> >>>+ isb();
> >>> }
> >>>
> >>> static inline u64 arch_counter_get_cntpct(void)
> >>>diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
> >>>index fd4b7f6..47cf15e 100644
> >>>--- a/drivers/clocksource/arm_arch_timer.c
> >>>+++ b/drivers/clocksource/arm_arch_timer.c
> >>>@@ -77,6 +77,7 @@ struct arch_timer {
> >>> static bool arch_counter_suspend_stop;
> >>> static bool vdso_default = true;
> >>>
> >>>+static cpumask_t evtstrm_available;
> >>> static bool evtstrm_enable = IS_ENABLED(CONFIG_ARM_ARCH_TIMER_EVTSTREAM);
> >>>
> >>> static int __init early_evtstrm_cfg(char *buf)
> >>>@@ -740,6 +741,7 @@ static void arch_timer_evtstrm_enable(int divider)
> >>> #ifdef CONFIG_COMPAT
> >>> compat_elf_hwcap |= COMPAT_HWCAP_EVTSTRM;
> >>> #endif
> >>>+ cpumask_set_cpu(smp_processor_id(), &evtstrm_available);
> >>> }
> >>>
> >>> static void arch_timer_configure_evtstream(void)
> >>>@@ -864,6 +866,11 @@ u32 arch_timer_get_rate(void)
> >>> return arch_timer_rate;
> >>> }
> >>>
> >>>+bool arch_timer_evtstrm_available(void)
> >>>+{
> >>>+ return !!cpumask_test_cpu(smp_processor_id(), &evtstrm_available);
> >>>+}
> >>>+
> >>
> >>This could live in the header file as static inlin, if the evtstrm_available
> >>is made global and could avoid a function call where it is used.
> >
> >You might need an EXPORT_SYMBOl as well if you go down that route.
>
> Hmmm, I'm not fond of making the cpu mask global. I understand you can avoid
> the branch + ret of the function, but generally you want to check if the
> event stream is present to know if you can use wfe and wake up, so I don't
> think it might be used in a performance critical path.
>
> So I'm wondering, is it really worth it?
I have no strong preference, but I think you'll need o EXPORT something
either way so that delay and friends can be used from modules.
Will
next prev parent reply other threads:[~2017-10-12 10:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-29 10:52 [PATCH v3 0/2] WFE for long delays Julien Thierry
2017-09-29 10:52 ` [PATCH v3 1/2] arm_arch_timer: Expose event stream status Julien Thierry
2017-10-11 15:14 ` Will Deacon
2017-10-12 8:38 ` Julien Thierry
2017-10-12 8:58 ` Julien Thierry
2017-10-12 9:27 ` Suzuki K Poulose
2017-10-12 9:30 ` Will Deacon
2017-10-12 9:40 ` Julien Thierry
2017-10-12 10:26 ` Will Deacon [this message]
2017-10-12 12:28 ` Julien Thierry
2017-09-29 10:52 ` [PATCH v3 2/2] arm64: use WFE for long delays Julien Thierry
2017-10-11 15:13 ` Will Deacon
2017-10-12 8:47 ` Julien Thierry
2017-10-12 8:52 ` Will Deacon
2017-10-12 8:54 ` Julien Thierry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171012102612.GB7395@arm.com \
--to=will.deacon@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox