From: LW@KARO-electronics•de (Lothar Waßmann)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 3/4] ARM: dts: imx28-tx28: fix interrupt flags and use interrupts-extended property
Date: Wed, 18 Oct 2017 08:40:59 +0200 [thread overview]
Message-ID: <20171018084059.022d8116@karo-electronics.de> (raw)
In-Reply-To: <20171018021331.GC18810@dragon>
Hi,
On Wed, 18 Oct 2017 10:13:32 +0800 Shawn Guo wrote:
> On Mon, Oct 16, 2017 at 10:56:32AM +0200, Lothar Wa?mann wrote:
> > Hi,
> >
> > On Mon, 16 Oct 2017 09:17:26 +0200 Uwe Kleine-K?nig wrote:
> > > Hello,
> > >
> > > On Wed, Oct 11, 2017 at 01:05:38PM +0200, Lothar Wa?mann wrote:
> > > > diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts
> > > > index 211e67d..3c852f7 100644
> > > > --- a/arch/arm/boot/dts/imx28-tx28.dts
> > > > +++ b/arch/arm/boot/dts/imx28-tx28.dts
> > > > @@ -328,8 +328,7 @@
> > > > reg = <0x20>;
> > > > pinctrl-names = "default";
> > > > pinctrl-0 = <&tx28_pca9554_pins>;
> > > > - interrupt-parent = <&gpio3>;
> > > > - interrupts = <28 0>;
> > > > + interrupts-extended = <&gpio3 28 IRQ_TYPE_NONE>;
> > > > gpio-controller;
> > > > #gpio-cells = <2>;
> > > > interrupt-controller;
> > >
> > > While interrupts-extended looks nice,
> > > Documentation/devicetree/bindings/interrupt-controller/interrupts.txt
> > > has:
> > >
> > > "interrupts-extended" should only be used when a device has
> > > multiple interrupt parents.
> > >
> > > If this is still true, this patch is wrong.
> > >
> > Thanks for the hint. It really helps to read the documentation
> > sometimes, rahter than relying on existing code only...
> >
> > A quick check shows, that more than 100 of the 130 uses of
> > interrupts-extended are wrong. :(
>
> So should I drop all interrupts-extended patches from you?
>
Yes, please. Since this patch, and the corresponding patch for tx53
also fixed the interrupt flags, I will send new patches to only fix
the interrupt flags.
Lothar Wa?mann
next prev parent reply other threads:[~2017-10-18 6:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 11:05 [PATCH 0/4] ARM: dts: imx28: Update Ka-Ro TX28 dts file Lothar Waßmann
2017-10-11 11:05 ` [PATCH 1/4] ARM: dts: imx28-tx28: Relicense the TX28 dts file under GPLv2/X11 Lothar Waßmann
2017-10-11 11:05 ` [PATCH 2/4] ARM: dts: imx28-tx28: remove the regulators bus Lothar Waßmann
2017-10-11 11:05 ` [PATCH 3/4] ARM: dts: imx28-tx28: fix interrupt flags and use interrupts-extended property Lothar Waßmann
2017-10-16 7:17 ` Uwe Kleine-König
2017-10-16 8:56 ` Lothar Waßmann
2017-10-16 9:03 ` interrupts-extended only allowed with different parents? [Was: Re: [PATCH 3/4] ARM: dts: imx28-tx28: fix interrupt flags and use interrupts-extended property] Uwe Kleine-König
2017-10-16 21:29 ` Rob Herring
2017-10-18 2:13 ` [PATCH 3/4] ARM: dts: imx28-tx28: fix interrupt flags and use interrupts-extended property Shawn Guo
2017-10-18 6:40 ` Lothar Waßmann [this message]
2017-10-23 0:20 ` Shawn Guo
2017-10-11 11:05 ` [PATCH 4/4] ARM: dts: imx28-tx28: add trickle-charge config for DS1339 Lothar Waßmann
2017-10-14 15:08 ` [PATCH 0/4] ARM: dts: imx28: Update Ka-Ro TX28 dts file Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171018084059.022d8116@karo-electronics.de \
--to=lw@karo-electronics$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox