From: andrew@lunn•ch (Andrew Lunn)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] ARM: dts: imx53-cx9020: Fix the Ethernet PHY reset GPIO polarity
Date: Mon, 27 Nov 2017 14:29:03 +0100 [thread overview]
Message-ID: <20171127132903.GD19413@lunn.ch> (raw)
In-Reply-To: <1511650267-21933-1-git-send-email-festevam@gmail.com>
On Sat, Nov 25, 2017 at 08:51:07PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp•com>
>
> As explained in Documentation/devicetree/bindings/net/fsl-fec.txt the
> phy-reset-gpios is active high only if the 'phy-reset-active-high' is
> present.
>
> As 'phy-reset-active-high' is not used here, fix the device tree
> description by passing GPIO_ACTIVE_LOW flag.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp•com>
Hi Fabio
Do you have a bigger plan than just 'documentation'. Given that device
tree is an ABI, the GPIO_ACTIVE_ flag has to be ignored. Having it
correct is just documentation.
If you want to fix them all, is it worth adding in a warning to detect
a miss match between the GPIO_ACTIVE_* and phy-reset-active-high?
Reviewed-by: Andrew Lunn <andrew@lunn•ch>
Andrew
next prev parent reply other threads:[~2017-11-27 13:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-25 22:51 [PATCH] ARM: dts: imx53-cx9020: Fix the Ethernet PHY reset GPIO polarity Fabio Estevam
2017-11-27 4:55 ` Patrick Brünn
2017-11-27 13:29 ` Andrew Lunn [this message]
2017-11-27 13:35 ` Fabio Estevam
2017-11-29 7:00 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171127132903.GD19413@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox