From: andrew@lunn•ch (Andrew Lunn)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH 1/3 v3] ARM: dts: Add WAN ethernet port to the SQ201
Date: Wed, 11 Jul 2018 22:08:34 +0200 [thread overview]
Message-ID: <20180711200834.GE21430@lunn.ch> (raw)
In-Reply-To: <20180711194720.25266-1-linus.walleij@linaro.org>
On Wed, Jul 11, 2018 at 09:47:18PM +0200, Linus Walleij wrote:
> This sets up the ethernet interface and PHY for the
> WAN ethernet port which uses a Marvell PHY.
>
> Signed-off-by: Linus Walleij <linus.walleij@linaro•org>
> ---
> ChangeLog v2->v3:
> - No changes, just resending.
> ChangeLog v1->v2:
> - Rename wrongly named "ethernet-phy" to "mdio"
> - Drop device_type from the ethernet phy
> ---
> arch/arm/boot/dts/gemini-sq201.dts | 85 ++++++++++++++++++++++++++++++
> 1 file changed, 85 insertions(+)
>
> diff --git a/arch/arm/boot/dts/gemini-sq201.dts b/arch/arm/boot/dts/gemini-sq201.dts
> index 7658e212e6d2..cc693e64faaf 100644
> --- a/arch/arm/boot/dts/gemini-sq201.dts
> +++ b/arch/arm/boot/dts/gemini-sq201.dts
> @@ -55,6 +55,21 @@
> };
> };
>
> + mdio0: ethernet-phy {
Hi Linus
mdio0: mdio {
This is not a phy. Which is odd, because v1->v2 should of fixed this...
> + compatible = "virtual,mdio-gpio";
> + /* Uses MDC and MDIO */
> + gpios = <&gpio0 22 GPIO_ACTIVE_HIGH>, /* MDC */
> + <&gpio0 21 GPIO_ACTIVE_HIGH>; /* MDIO */
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + /* This is a Marvell 88E1111 ethernet transciever */
> + phy0: ethernet-phy at 1 {
> + reg = <1>;
> + device_type = "ethernet-phy";
???
I'm wondering if this is the correct version of these patches....
Andrew
next prev parent reply other threads:[~2018-07-11 20:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 19:47 [PATCH 1/3 v3] ARM: dts: Add WAN ethernet port to the SQ201 Linus Walleij
2018-07-11 19:47 ` [PATCH 2/3 v3] ARM: dts: Att Vitesse G5e switch to the Gemini SQ201 Linus Walleij
2018-07-11 19:47 ` [PATCH 3/3 v3] ARM: dts: Add devicetree for Storlink/Storm SL93512R Linus Walleij
2018-07-11 20:08 ` Andrew Lunn [this message]
2018-07-13 8:00 ` [PATCH 1/3 v3] ARM: dts: Add WAN ethernet port to the SQ201 Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180711200834.GE21430@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox