From: will.deacon@arm•com (Will Deacon)
To: linux-arm-kernel@lists•infradead.org
Subject: [PATCH] arm64: fix infinite stacktrace
Date: Thu, 12 Jul 2018 11:39:23 +0100 [thread overview]
Message-ID: <20180712103922.GC23415@arm.com> (raw)
In-Reply-To: <alpine.LRH.2.02.1807101408150.30968@file01.intranet.prod.int.rdu2.redhat.com>
On Tue, Jul 10, 2018 at 02:10:04PM -0400, Mikulas Patocka wrote:
> On Tue, 10 Jul 2018, Will Deacon wrote:
> > On Mon, Jul 09, 2018 at 11:04:33PM -0400, Mikulas Patocka wrote:
> > > Index: linux-2.6/arch/arm64/kernel/stacktrace.c
> > > ===================================================================
> > > --- linux-2.6.orig/arch/arm64/kernel/stacktrace.c 2018-07-10 05:01:56.990000000 +0200
> > > +++ linux-2.6/arch/arm64/kernel/stacktrace.c 2018-07-10 05:02:51.650000000 +0200
> > > @@ -56,6 +56,9 @@ int notrace unwind_frame(struct task_str
> > > frame->fp = READ_ONCE_NOCHECK(*(unsigned long *)(fp));
> > > frame->pc = READ_ONCE_NOCHECK(*(unsigned long *)(fp + 8));
> > >
> > > + if (frame->fp == fp)
> > > + return -EINVAL;
> >
> > I've already queued your previous patch using '<=' (it's in -next). If you
> > want to change it, please send patches on top of the arm64 for-next/core
> > branch.
> >
> > Will
>
> I don't know - is this function supposed to backtrace against more
> discontiguous stacks? If yes, then the patch with (frame->fp <= fp) is
> incorrect. If no, then the condition (frame->fp <= fp) could be there.
Ah yes, your original patch breaks with irqstacks, so I'll need to revert
it. Using '==' feels like a big hack to me.
Will
prev parent reply other threads:[~2018-07-12 10:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-14 18:58 [PATCH] arm64: fix infinite stacktrace Mikulas Patocka
2018-06-15 11:58 ` Mark Rutland
2018-06-27 16:41 ` Will Deacon
2018-06-28 16:49 ` Dave Martin
2018-07-10 3:04 ` Mikulas Patocka
2018-07-10 9:13 ` Will Deacon
2018-07-10 18:10 ` Mikulas Patocka
2018-07-12 10:39 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180712103922.GC23415@arm.com \
--to=will.deacon@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox