public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@redhat•com>
To: Ravi Bangoria <ravi.bangoria@linux•ibm.com>
Cc: linux-mips@linux-mips•org, srikar@linux•vnet.ibm.com,
	peterz@infradead•org, jolsa@redhat•com, ralf@linux-mips•org,
	liu.song.a23@gmail•com, linux-kernel@vger•kernel.org,
	rostedt@goodmis•org, linux@armlinux•org.uk,
	alexander.shishkin@linux•intel.com, paul.burton@mips•com,
	mingo@redhat•com, mhiramat@kernel•org, ananth@linux•vnet.ibm.com,
	namhyung@kernel•org, naveen.n.rao@linux•vnet.ibm.com,
	alexis.berlemont@gmail•com, acme@kernel•org,
	linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH v2] Uprobes: Fix kernel oops with delayed_uprobe_remove()
Date: Wed, 5 Dec 2018 15:39:14 +0100	[thread overview]
Message-ID: <20181205143914.GB9535@redhat.com> (raw)
In-Reply-To: <20181205033423.26242-1-ravi.bangoria@linux.ibm.com>

On 12/05, Ravi Bangoria wrote:
>
> --- a/kernel/events/uprobes.c
> +++ b/kernel/events/uprobes.c
> @@ -572,7 +572,9 @@ static void put_uprobe(struct uprobe *uprobe)
>  		 * gets called, we don't get a chance to remove uprobe from
>  		 * delayed_uprobe_list from remove_breakpoint(). Do it here.
>  		 */
> +		mutex_lock(&delayed_uprobe_lock);
>  		delayed_uprobe_remove(uprobe, NULL);
> +		mutex_unlock(&delayed_uprobe_lock);
>  		kfree(uprobe);

Acked-by: Oleg Nesterov <oleg@redhat•com>


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      parent reply	other threads:[~2018-12-05 14:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-14  8:19 [PATCH] Uprobes: Fix kernel oops with delayed_uprobe_remove() Ravi Bangoria
2018-11-14 16:06 ` Oleg Nesterov
2018-11-15  4:06   ` Ravi Bangoria
2018-11-15 12:43     ` Oleg Nesterov
2018-12-03  6:22       ` Ravi Bangoria
2018-12-04  5:58         ` Steven Rostedt
2018-12-05  3:34           ` [PATCH v2] " Ravi Bangoria
2018-12-05 10:01             ` Srikar Dronamraju
2018-12-05 14:39             ` Oleg Nesterov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181205143914.GB9535@redhat.com \
    --to=oleg@redhat$(echo .)com \
    --cc=acme@kernel$(echo .)org \
    --cc=alexander.shishkin@linux$(echo .)intel.com \
    --cc=alexis.berlemont@gmail$(echo .)com \
    --cc=ananth@linux$(echo .)vnet.ibm.com \
    --cc=jolsa@redhat$(echo .)com \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-mips@linux-mips$(echo .)org \
    --cc=linux@armlinux$(echo .)org.uk \
    --cc=liu.song.a23@gmail$(echo .)com \
    --cc=mhiramat@kernel$(echo .)org \
    --cc=mingo@redhat$(echo .)com \
    --cc=namhyung@kernel$(echo .)org \
    --cc=naveen.n.rao@linux$(echo .)vnet.ibm.com \
    --cc=paul.burton@mips$(echo .)com \
    --cc=peterz@infradead$(echo .)org \
    --cc=ralf@linux-mips$(echo .)org \
    --cc=ravi.bangoria@linux$(echo .)ibm.com \
    --cc=rostedt@goodmis$(echo .)org \
    --cc=srikar@linux$(echo .)vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox