From: Thomas Petazzoni <thomas.petazzoni@bootlin•com>
To: Linus Walleij <linus.walleij@linaro•org>
Cc: "Josh Cartwright" <josh.cartwright@ni•com>,
"Peter Crosthwaite" <peter.crosthwaite@xilinx•com>,
"Nava kishore Manne" <navam@xilinx•com>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"monstr@monstr•eu" <monstr@monstr•eu>,
"Borsodi Petr" <Petr.Borsodi@i•cz>,
"Michal Simek" <michal.simek@xilinx•com>,
"linux-gpio@vger•kernel.org" <linux-gpio@vger•kernel.org>,
"Rob Herring" <robherring2@gmail•com>,
"Sören Brinkmann" <soren.brinkmann@xilinx•com>,
"Steffen Trumtrar" <s.trumtrar@pengutronix•de>,
"Shubhrajyoti Datta" <shubhraj@xilinx•com>,
"linux-arm-kernel@lists•infradead.org"
<linux-arm-kernel@lists•infradead.org>
Subject: Re: [PATCH 2/8] gpio: zynq: Wakeup gpio controller when it is used as IRQ controller
Date: Fri, 11 Jan 2019 13:54:13 +0100 [thread overview]
Message-ID: <20190111135413.73dad0b2@windsurf> (raw)
In-Reply-To: <CACRpkdafBpC14TxBNVN2AemkBz-yKkXkKfNpdgkYKQX3qFemag@mail.gmail.com>
Hello Linus,
On Fri, 11 Jan 2019 10:54:20 +0100, Linus Walleij wrote:
> My stance is that the driver is responsible of enabling and managing
> runtime PM for its hardware block(s).
>
> Runtime PM in the core should only be added if the core needs to
> be aware about it, such as is the case when e.g. a block device
> needs to drain its write buffer before going to runtime sleep.
>
> I fail so see why the GPIO core need to be aware about this.
In this very same thread at
https://www.spinics.net/lists/arm-kernel/msg600515.html, you kind of
proposed to handle this in the core in fact :-) Though indeed you said
that the core could provide helpers.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-11 12:54 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-07 11:01 [PATCH 0/8] Zynq GPIO driver changes Michal Simek
2017-08-07 11:01 ` [PATCH 1/8] gpio: zynq: Add support for suspend resume Michal Simek
2017-08-14 13:44 ` Linus Walleij
2017-08-07 11:01 ` [PATCH 2/8] gpio: zynq: Wakeup gpio controller when it is used as IRQ controller Michal Simek
2017-08-14 13:53 ` Linus Walleij
2017-08-14 14:33 ` Michal Simek
2017-08-22 12:57 ` Linus Walleij
2019-01-07 15:42 ` Thomas Petazzoni
2019-01-08 13:21 ` Michal Simek
2019-01-11 9:54 ` Linus Walleij
2019-01-11 12:54 ` Thomas Petazzoni [this message]
2019-01-11 14:37 ` Linus Walleij
2019-01-21 6:11 ` Shubhrajyoti Datta
2017-08-07 11:01 ` [PATCH 3/8] gpio: zynq: Shift zynq_gpio_init() to subsys_initcall level Michal Simek
2017-08-14 13:55 ` Linus Walleij
2017-08-14 14:15 ` Michal Simek
2017-08-22 13:02 ` Linus Walleij
2017-08-07 11:01 ` [PATCH 4/8] gpio: zynq: Provided workaround for GPIO Michal Simek
2017-08-14 13:57 ` Linus Walleij
2017-08-14 14:01 ` Michal Simek
2017-08-07 11:01 ` [PATCH 5/8] gpio: zynq: Fix kernel doc warnings Michal Simek
2017-08-14 13:58 ` Linus Walleij
2017-08-07 11:01 ` [PATCH 6/8] gpio: zynq: Fix empty lines in driver Michal Simek
2017-08-14 13:59 ` Linus Walleij
2017-08-07 11:02 ` [PATCH 7/8] gpio: zynq: Fix warnings in the driver Michal Simek
2017-08-14 14:00 ` Linus Walleij
2017-08-07 11:02 ` [PATCH 8/8] gpio: zynq: Fix driver function parameters alignment Michal Simek
2017-08-14 14:01 ` Linus Walleij
2017-08-14 14:03 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190111135413.73dad0b2@windsurf \
--to=thomas.petazzoni@bootlin$(echo .)com \
--cc=Petr.Borsodi@i$(echo .)cz \
--cc=josh.cartwright@ni$(echo .)com \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-gpio@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=michal.simek@xilinx$(echo .)com \
--cc=monstr@monstr$(echo .)eu \
--cc=navam@xilinx$(echo .)com \
--cc=peter.crosthwaite@xilinx$(echo .)com \
--cc=robherring2@gmail$(echo .)com \
--cc=s.trumtrar@pengutronix$(echo .)de \
--cc=shubhraj@xilinx$(echo .)com \
--cc=soren.brinkmann@xilinx$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox