Subject: Re: [PATCH 3/4] ARM: dts: imx6qdl-phytec-pfla02: Replace magic numbers

From: Shawn Guo <[email-masked]>
Date: Sat, 12 Jan 2019 11:13:19 +0800

On Sun, Dec 23, 2018 at 07:31:40PM +0300, Alexander Shiyan wrote:
> Use GPIO_ACTIVE_LOW/HIGH for GPIO description.
> 
> Signed-off-by: Alexander Shiyan <[email-masked]>
> ---
>  arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> index 211640e..81007d6 100644
> --- a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> @@ -23,7 +23,7 @@
>  			regulator-name = "usb_otg_vbus";
>  			regulator-min-microvolt = <5000000>;
>  			regulator-max-microvolt = <5000000>;
> -			gpio = <&gpio4 15 0>;
> +			gpio = <&gpio4 15 GPIO_ACTIVE_HIGH>;
>  			enable-active-high;
>  		};
>  
> @@ -33,7 +33,7 @@
>  			regulator-name = "usb_h1_vbus";
>  			regulator-min-microvolt = <5000000>;
>  			regulator-max-microvolt = <5000000>;
> -			gpio = <&gpio1 0 0>;
> +			gpio = <&gpio1 0 GPIO_ACTIVE_HIGH>;
>  			enable-active-high;
>  		};
>  	};
> @@ -43,12 +43,12 @@
>  
>  		green {
>  			label = "phyflex:green";
> -			gpios = <&gpio1 30 0>;
> +			gpios = <&gpio1 30 GPIO_ACTIVE_HIGH>;
>  		};
>  
>  		red {
>  			label = "phyflex:red";
> -			gpios = <&gpio2 31 0>;
> +			gpios = <&gpio2 31 GPIO_ACTIVE_HIGH>;
>  		};
>  	};
>  };
> @@ -69,7 +69,7 @@
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_ecspi3>;
>  	status = "okay";
> -	cs-gpios = <&gpio4 24 0>;
> +	cs-gpios = <&gpio4 24 GPIO_ACTIVE_LOW>;

GPIO_ACTIVE_LOW is defined as 1 rather than 0.

Shawn

>  
>  	flash@0 {
>  		compatible = "m25p80", "jedec,spi-nor";
> -- 
> 2.10.2
> 

_______________________________________________
linux-arm-kernel mailing list
[email-masked]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel