Subject: Re: [PATCH 4/4] ARM: dts: imx6qdl-phytec-pfla02: Add some labels

From: Shawn Guo <[email-masked]>
Date: Sat, 12 Jan 2019 11:21:57 +0800

On Sun, Dec 23, 2018 at 07:31:41PM +0300, Alexander Shiyan wrote:
> This patch adds labels to devices that can be reused in top-level dts.
> 
> Signed-off-by: Alexander Shiyan <[email-masked]>
> ---
>  arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> index 81007d6..a685ff7 100644
> --- a/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-phytec-pfla02.dtsi
> @@ -41,12 +41,12 @@
>  	gpio_leds: leds {
>  		compatible = "gpio-leds";
>  
> -		green {
> +		led_green: led_green {

We usually use hyphen than underscore in node name, so led-green for
node please.

>  			label = "phyflex:green";
>  			gpios = <&gpio1 30 GPIO_ACTIVE_HIGH>;
>  		};
>  
> -		red {
> +		led_red: led_red {

Ditto

>  			label = "phyflex:red";
>  			gpios = <&gpio2 31 GPIO_ACTIVE_HIGH>;
>  		};
> @@ -71,7 +71,7 @@
>  	status = "okay";
>  	cs-gpios = <&gpio4 24 GPIO_ACTIVE_LOW>;
>  
> -	flash@0 {
> +	flash: flash@0 {

Please use a specific name for labelling, for example:

	m25p80: flash@0 {

>  		compatible = "m25p80", "jedec,spi-nor";
>  		spi-max-frequency = <20000000>;
>  		reg = <0>;
> @@ -99,12 +99,12 @@
>  	pinctrl-0 = <&pinctrl_i2c1>;
>  	status = "okay";
>  
> -	eeprom@50 {
> +	eeprom: eeprom@50 {

Ditto

>  		compatible = "atmel,24c32";
>  		reg = <0x50>;
>  	};
>  
> -	pmic@58 {
> +	pmic: pmic@58 {

Ditto

Shawn

>  		compatible = "dlg,da9063";
>  		reg = <0x58>;
>  		interrupt-parent = <&gpio2>;
> -- 
> 2.10.2
> 

_______________________________________________
linux-arm-kernel mailing list
[email-masked]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel