Subject: Re: [PATCH v3 04/10] usb: ehci-orion: add S2RAM support

From: Miquel Raynal <[email-masked]>
Date: Fri, 25 Jan 2019 11:35:38 +0100

Hi Alan,

Alan Stern <[email-masked]> wrote on Wed, 23 Jan 2019
14:58:44 -0500 (EST):

> On Mon, 21 Jan 2019, Miquel Raynal wrote:
> 
> > Add suspend/resume callbacks to reset the host controller properly
> > during S2RAM operation.
> > 
> > Signed-off-by: Miquel Raynal <[email-masked]>
> > ---
> >  drivers/usb/host/ehci-orion.c | 25 +++++++++++++++++++++++++
> >  1 file changed, 25 insertions(+)
> > 
> > diff --git a/drivers/usb/host/ehci-orion.c b/drivers/usb/host/ehci-orion.c
> > index 3109f082949e..dab22aa57c0b 100644
> > --- a/drivers/usb/host/ehci-orion.c
> > +++ b/drivers/usb/host/ehci-orion.c
> > @@ -182,6 +182,30 @@ static int ehci_orion_drv_reset(struct usb_hcd *hcd)
> >  	return ret;
> >  }
> >  
> > +static int __maybe_unused ehci_orion_drv_suspend(struct device *dev)
> > +{
> > +	struct usb_hcd *hcd = dev_get_drvdata(dev);
> > +	struct ehci_hcd *ehci = hcd_to_ehci(hcd);
> > +
> > +	ehci_prepare_ports_for_controller_suspend(ehci,
> > +						  device_may_wakeup(dev));
> > +
> > +	return ehci_suspend(hcd, false);  
> 
> This is a little odd.  Why not just call
> 
> 	ehci_suspend(hcd, device_may_wakeup(dev));
> 
> directly and let it take care of calling
> ehci_prepare_ports_for_controller_suspend() for you?  If you have a
> good reason for doing things this way, please mention that reason in
> the Changelog.

There is no reason, I think I got the inspiration from an other driver
calling manually ehci_prepare_ports_for_controller_suspend(), but I did
not check it was already taken care of by ehci_suspend/resume().

Call removed in both paths, thanks!
Miquèl

_______________________________________________
linux-arm-kernel mailing list
[email-masked]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel