From: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
To: Will Deacon <will.deacon@arm•com>
Cc: Kevin Hilman <khilman@kernel•org>,
Marc Zyngier <marc.zyngier@arm•com>,
Catalin Marinas <catalin.marinas@arm•com>,
Russell King <linux@armlinux•org.uk>,
Peng Donglin <dolinux.peng@gmail•com>,
linux-kernel@vger•kernel.org,
linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH 1/4] arm64: dump: no need to check return value of debugfs_create functions
Date: Wed, 30 Jan 2019 20:33:48 +0100 [thread overview]
Message-ID: <20190130193348.GC20667@kroah.com> (raw)
In-Reply-To: <20190130182102.GK18558@fuggles.cambridge.arm.com>
On Wed, Jan 30, 2019 at 06:21:02PM +0000, Will Deacon wrote:
> Hi Greg,
>
> On Tue, Jan 22, 2019 at 03:41:11PM +0100, Greg Kroah-Hartman wrote:
> > When calling debugfs functions, there is no need to ever check the
> > return value. The function can work or not, but the code logic should
> > never do something different based on this.
> >
> > Cc: Catalin Marinas <catalin.marinas@arm•com>
> > Cc: Will Deacon <will.deacon@arm•com>
> > Cc: Marc Zyngier <marc.zyngier@arm•com>
> > Cc: Peng Donglin <dolinux.peng@gmail•com>
> > Cc: <linux-arm-kernel@lists•infradead.org>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
> > ---
> > arch/arm64/include/asm/ptdump.h | 9 +++------
> > arch/arm64/mm/dump.c | 4 ++--
> > arch/arm64/mm/ptdump_debugfs.c | 7 ++-----
> > 3 files changed, 7 insertions(+), 13 deletions(-)
>
> Are you taking this via your tree, or would you like us to queue it in
> arm64?
What ever is easiest for you is fine with me, I can handle it either
way, just let me know.
thanks,
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-30 19:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 14:41 [PATCH 0/4] ARM: cleanup debugfs usage Greg Kroah-Hartman
2019-01-22 14:41 ` [PATCH 1/4] arm64: dump: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-01-25 18:13 ` Catalin Marinas
2019-01-30 18:21 ` Will Deacon
2019-01-30 19:33 ` Greg Kroah-Hartman [this message]
2019-01-31 13:57 ` Will Deacon
2019-01-22 14:41 ` [PATCH 2/4] arm: " Greg Kroah-Hartman
2019-01-22 21:25 ` Kees Cook
2019-01-23 9:42 ` Laura Abbott
2019-01-22 14:41 ` [PATCH 3/4] arm: omap1: " Greg Kroah-Hartman
2019-01-22 23:05 ` Tony Lindgren
2019-01-22 14:41 ` [PATCH 4/4] arm: omap2: " Greg Kroah-Hartman
2019-01-22 23:06 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190130193348.GC20667@kroah.com \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=catalin.marinas@arm$(echo .)com \
--cc=dolinux.peng@gmail$(echo .)com \
--cc=khilman@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=marc.zyngier@arm$(echo .)com \
--cc=will.deacon@arm$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox