Subject: Re: [PATCH v3] mtd: rawnand: atmel: fix possible object reference leak

From: Miquel Raynal <[email-masked]>
Date: Tue, 5 Feb 2019 15:37:45 +0100

Hi Wen,

Wen Yang <[email-masked]> wrote on Tue, 5 Feb 2019
14:32:41 +0000:

> of_find_device_by_node() takes a reference to the struct device
> when it finds a match via get_device, there is no need to call
> get_device() twice.
> We also should make sure to drop the reference to the device
> taken by of_find_device_by_node() on driver unbind.
> 
> Fixes: f88fc122cc34 ("mtd: nand: Cleanup/rework the atmel_nand driver")
> Signed-off-by: Wen Yang <[email-masked]>
> Suggested-by: Boris Brezillon <[email-masked]>
> Reviewed-by: Boris Brezillon <[email-masked]>
> Reviewed-by: Miquel Raynal <[email-masked]>

Please stop adding "Reviewed-by" tags from us if we did not write them!

> Acked-by: Miquel Raynal <[email-masked]>
> Cc: Tudor Ambarus <[email-masked]>
> Cc: Boris Brezillon <[email-masked]>
> Cc: Miquel Raynal <[email-masked]>
> Cc: Richard Weinberger <[email-masked]>
> Cc: David Woodhouse <[email-masked]>
> Cc: Brian Norris <[email-masked]>
> Cc: Marek Vasut <[email-masked]>
> Cc: Nicolas Ferre <[email-masked]>
> Cc: Alexandre Belloni <[email-masked]>
> Cc: Ludovic Desroches <[email-masked]>
> Cc: [email-masked]
> Cc: [email-masked]
> Cc: [email-masked]
> ---

And for the other patches, please append a changelog explaining the
evolutions of the patch through the versions below the three dashes
'---'.

Thanks,
Miquèl

_______________________________________________
linux-arm-kernel mailing list
[email-masked]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel