Subject: Re: [RFC PATCH 10/27] mtd: rawnand: Get rid of chip->ecc.priv

From: Boris Brezillon <[email-masked]>
Date: Thu, 21 Feb 2019 14:01:01 +0100

On Thu, 21 Feb 2019 11:01:59 +0100
Miquel Raynal <[email-masked]> wrote:

> nand_ecc_ctrl embeds a private pointer which had only a meaning in the
> sunxi driver. This structure will soon be deprecated, but as this
> field is actually not needed, let's just drop it.
> 
> Signed-off-by: Miquel Raynal <[email-masked]>
> ---
>  drivers/mtd/nand/raw/sunxi_nand.c | 29 ++++++++++++++---------------
>  include/linux/mtd/rawnand.h       |  2 --
>  2 files changed, 14 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/mtd/nand/raw/sunxi_nand.c b/drivers/mtd/nand/raw/sunxi_nand.c
> index b56f89c992f3..d05f71f33b5c 100644
> --- a/drivers/mtd/nand/raw/sunxi_nand.c
> +++ b/drivers/mtd/nand/raw/sunxi_nand.c
> @@ -230,6 +230,7 @@ static inline struct sunxi_nand_chip *to_sunxi_nand(struct nand_chip *nand)
>   *			this NAND controller
>   * @complete:		a completion object used to wait for NAND
>   *			controller events
> + * @ecc:		ECC controller structure
>   */
>  struct sunxi_nfc {
>  	struct nand_controller controller;
> @@ -243,6 +244,7 @@ struct sunxi_nfc {
>  	struct list_head chips;
>  	struct completion complete;
>  	struct dma_chan *dmac;
> +	struct sunxi_nand_hw_ecc *ecc;

It's a per-chip object, not a per-controller one, should be moved to
sunxi_nand_chip.

>  };

_______________________________________________
linux-arm-kernel mailing list
[email-masked]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel