Subject: Re: [PATCH] ARM: imx6: cpuidle: omit the unnecessary unmask of GINT

From: Shawn Guo <[email-masked]>
Date: Tue, 19 Mar 2019 20:51:50 +0800

On Wed, Mar 06, 2019 at 01:30:42PM +0900, Kohji Okuno wrote:
> In imx6_set_lpm, we only need to unmask GINT when not WAIT_CLOCKED,
> so add a check condition.

Can you elaborate the problem we have without this code change?

Shawn

> 
> Signed-off-by: Peng Fan <[email-masked]>
> Signed-off-by: Kohji Okuno <[email-masked]>
> ---
>  arch/arm/mach-imx/pm-imx6.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-imx/pm-imx6.c b/arch/arm/mach-imx/pm-imx6.c
> index 87f45b926c78..54add0178b96 100644
> --- a/arch/arm/mach-imx/pm-imx6.c
> +++ b/arch/arm/mach-imx/pm-imx6.c
> @@ -354,9 +354,11 @@ int imx6_set_lpm(enum mxc_cpu_pwr_mode mode)
>  	 *
>  	 * Note that IRQ #32 is GIC SPI #0.
>  	 */
> -	imx_gpc_hwirq_unmask(0);
> +	if (mode != WAIT_CLOCKED)
> +		imx_gpc_hwirq_unmask(0);
>  	writel_relaxed(val, ccm_base + CLPCR);
> -	imx_gpc_hwirq_mask(0);
> +	if (mode != WAIT_CLOCKED)
> +		imx_gpc_hwirq_mask(0);
>  
>  	return 0;
>  }
> -- 
> 2.17.1
> 

_______________________________________________
linux-arm-kernel mailing list
[email-masked]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel