Subject: Re: [PATCH V3 2/2] ARM: dts: imx53: Add Menlosystems M53 board

From: Shawn Guo <[email-masked]>
Date: Wed, 20 Mar 2019 22:51:58 +0800

On Wed, Mar 20, 2019 at 09:32:38AM -0300, Fabio Estevam wrote:
> Hi Marek,
> 
> On Mon, Mar 4, 2019 at 9:12 AM Marek Vasut <[email-masked]> wrote:
> 
> > +       regulators {
> > +               compatible = "simple-bus";
> > +               #address-cells = <1>;
> > +               #size-cells = <0>;
> > +
> > +               reg_usbh1_vbus: regulator@3 {
> 
> Please move the regulator outside the 'simple-bus':
> 
> reg_usbh1_vbus: regulator-usbh1-vbus {
> 
> > +                       compatible = "regulator-fixed";
> > +                       reg = <3>;
> 
> The 'reg' property can also be removed.
> 
> > +                       regulator-name = "vbus";
> > +                       regulator-min-microvolt = <5000000>;
> > +                       regulator-max-microvolt = <5000000>;
> > +                       gpio = <&gpio1 2 0>;
> 
> The GPIO flag 0 means active high, but since you are not passing
> 'enable-active-high' this should be:
> 
>  gpio = <&gpio1 2 GPIO_ACTIVE_LOW>;
> 
> > +&i2c2 {
> > +       stmpe610@41 {
> 
> Node name should be generic, so:
> 
> touchscreen@41
> 
> > +&ldb {
> > +       pinctrl-names = "default";
> > +       pinctrl-0 = <&pinctrl_lvds0>;
> > +       status = "okay";
> > +
> > +       lvds0: lvds-channel@0 {
> 
> There is an @0 without a corresponding reg property. This triggers a
> dtc warning when building with W=1.
> 
> Please fix it.

Okay, I dropped the patch and wait for new version.

Shawn

_______________________________________________
linux-arm-kernel mailing list
[email-masked]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel