From: Jisheng Zhang <Jisheng.Zhang@synaptics•com>
To: Jon Hunter <jonathanh@nvidia•com>
Cc: "mark.rutland@arm•com" <mark.rutland@arm•com>,
"heiko@sntech•de" <heiko@sntech•de>,
"hayashi.kunihiko@socionext•com" <hayashi.kunihiko@socionext•com>,
"tiwai@suse•de" <tiwai@suse•de>,
"catalin.marinas@arm•com" <catalin.marinas@arm•com>,
"spujar@nvidia•com" <spujar@nvidia•com>,
"will.deacon@arm•com" <will.deacon@arm•com>,
"kthota@nvidia•com" <kthota@nvidia•com>,
"mperttunen@nvidia•com" <mperttunen@nvidia•com>,
"linux-tegra@vger•kernel.org" <linux-tegra@vger•kernel.org>,
"thierry.reding@gmail•com" <thierry.reding@gmail•com>,
"stefan.wahren@i2se•com" <stefan.wahren@i2se•com>,
"lorenzo.pieralisi@arm•com" <lorenzo.pieralisi@arm•com>,
"krzk@kernel•org" <krzk@kernel•org>,
"kishon@ti•com" <kishon@ti•com>,
"maxime.ripard@bootlin•com" <maxime.ripard@bootlin•com>,
"jagan@amarulasolutions•com" <jagan@amarulasolutions•com>,
"linux-pci@vger•kernel.org" <linux-pci@vger•kernel.org>,
"andy.gross@linaro•org" <andy.gross@linaro•org>,
"shawn.lin@rock-chips•com" <shawn.lin@rock-chips•com>,
"devicetree@vger•kernel.org" <devicetree@vger•kernel.org>,
"mmaddireddy@nvidia•com" <mmaddireddy@nvidia•com>,
"marc.w.gonzalez@free•fr" <marc.w.gonzalez@free•fr>,
"liviu.dudau@arm•com" <liviu.dudau@arm•com>,
"yue.wang@amlogic•com" <yue.wang@amlogic•com>,
"enric.balletbo@collabora•com" <enric.balletbo@collabora•com>,
"robh+dt@kernel•org" <robh+dt@kernel•org>,
Bjorn Helgaas <bhelgaas@google•com>,
"horms+renesas@verge•net.au" <horms+renesas@verge•net.au>,
"bjorn.andersson@linaro•org" <bjorn.andersson@linaro•org>,
"ezequiel@collabora•com" <ezequiel@collabora•com>,
"linux-arm-kernel@lists•infradead.org"
<linux-arm-kernel@lists•infradead.org>,
"xiaowei.bao@nxp•com" <xiaowei.bao@nxp•com>,
"gustavo.pimentel@synopsys•com" <gustavo.pimentel@synopsys•com>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
Vidya Sagar <vidyas@nvidia•com>,
"skomatineni@nvidia•com" <skomatineni@nvidia•com>,
"jingoohan1@gmail•com" <jingoohan1@gmail•com>,
"olof@lixom•net" <olof@lixom•net>,
"tpiepho@impinj•com" <tpiepho@impinj•com>,
"l.stach@pengutronix•de" <l.stach@pengutronix•de>
Subject: Re: [PATCH 10/10] arm64: Add Tegra194 PCIe driver to defconfig
Date: Thu, 28 Mar 2019 08:19:23 +0000 [thread overview]
Message-ID: <20190328161138.1b37d232@xhacker.debian> (raw)
In-Reply-To: <c5ca34fe-4290-d9b7-cda3-23b4a11ec5d8@nvidia.com>
On Wed, 27 Mar 2019 12:26:49 +0000 Jon Hunter wrote:
>
>
> On 27/03/2019 10:12, Vidya Sagar wrote:
> > On 3/27/2019 3:38 PM, Jon Hunter wrote:
> >>
> >> On 26/03/2019 15:13, Vidya Sagar wrote:
> >>> Add PCIe host controller driver for DesignWare core based
> >>> PCIe controller IP present in Tegra194.
> >>>
> >>> Signed-off-by: Vidya Sagar <vidyas@nvidia•com>
> >>> ---
> >>> arch/arm64/configs/defconfig | 1 +
> >>> 1 file changed, 1 insertion(+)
> >>>
> >>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> >>> index 2d9c39033c1a..2ddea5c4e87d 100644
> >>> --- a/arch/arm64/configs/defconfig
> >>> +++ b/arch/arm64/configs/defconfig
> >>> @@ -87,6 +87,7 @@ CONFIG_PCIE_QCOM=y
> >>> CONFIG_PCIE_ARMADA_8K=y
> >>> CONFIG_PCIE_KIRIN=y
> >>> CONFIG_PCIE_HISI_STB=y
> >>> +CONFIG_PCIE_TEGRA194=y
> >>> CONFIG_ARM64_VA_BITS_48=y
> >>> CONFIG_SCHED_MC=y
> >>> CONFIG_NUMA=y
> >>
> >> Maybe building as a module is more appropriate here as I am not sure
> >> that anyone else will want this built-in and it is not critical to
> >> booting AFAIK.
> > Since the DesignWare core framework doesn't yet have support for making
> > this
> > as a module, I added it as a built-in driver. I'll switch it to a module
> > once support is available.
>
> Ah I see. We often get reports/patches if a driver has a removal
> function but is defined in the Kconfig to only support being built-in.
>
> Does the designware core just need to export some symbols to support it
> being a module? If so it maybe worth adding these as part of the series
> to see if it is acceptable, otherwise it might not get done and there is
> no point us supporting it as a module.
After https://lkml.org/lkml/2019/3/18/363
we could implement the "remove"
Thanks
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-03-28 8:19 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 15:13 [PATCH 00/10] Add Tegra194 PCIe support Vidya Sagar
2019-03-26 15:13 ` [PATCH 01/10] PCI: save pci_bus pointer in pcie_port structure Vidya Sagar
2019-03-28 7:18 ` Jisheng Zhang
2019-03-28 7:38 ` Vidya Sagar
2019-03-26 15:13 ` [PATCH 02/10] PCI: perform dbi regs write lock towards the end Vidya Sagar
2019-03-26 15:13 ` [PATCH 03/10] PCI: dwc: Move config space capability search API Vidya Sagar
2019-03-28 12:33 ` Thierry Reding
2019-04-01 11:46 ` Vidya Sagar
2019-03-26 15:13 ` [PATCH 04/10] PCI: Add #defines for PCIe spec r4.0 features Vidya Sagar
2019-03-26 15:13 ` [PATCH 05/10] dt-bindings: PCI: tegra: Add device tree support for T194 Vidya Sagar
2019-03-27 10:10 ` Jon Hunter
2019-03-27 10:53 ` Vidya Sagar
2019-03-28 13:15 ` Thierry Reding
2019-04-01 10:01 ` Vidya Sagar
2019-04-01 15:07 ` Thierry Reding
2019-04-02 11:41 ` Vidya Sagar
2019-04-02 14:35 ` Thierry Reding
2019-04-03 6:22 ` Vidya Sagar
2019-04-02 19:21 ` Bjorn Helgaas
2019-03-31 6:42 ` Rob Herring
2019-04-01 11:18 ` Vidya Sagar
2019-04-01 14:31 ` Thierry Reding
2019-04-02 9:16 ` Vidya Sagar
2019-04-02 14:20 ` Thierry Reding
2019-04-03 5:29 ` Vidya Sagar
2019-04-08 18:29 ` Trent Piepho
2019-04-09 11:07 ` Vidya Sagar
2019-03-26 15:13 ` [PATCH 06/10] arm64: tegra: Add P2U and PCIe controller nodes to Tegra194 DT Vidya Sagar
2019-03-28 16:59 ` Thierry Reding
2019-04-01 12:37 ` Vidya Sagar
2019-03-26 15:13 ` [PATCH 07/10] arm64: tegra: Enable PCIe slots in P2972-0000 board Vidya Sagar
2019-03-26 15:13 ` [PATCH 08/10] phy: tegra: Add PCIe PIPE2UPHY support Vidya Sagar
2019-04-03 8:05 ` Kishon Vijay Abraham I
2019-04-03 10:45 ` Vidya Sagar
2019-03-26 15:13 ` [PATCH 09/10] PCI: tegra: Add Tegra194 PCIe support Vidya Sagar
2019-03-27 10:07 ` Jon Hunter
2019-03-29 20:52 ` Bjorn Helgaas
2019-04-02 7:17 ` Vidya Sagar
2019-04-02 14:14 ` Thierry Reding
2019-04-03 9:15 ` Vidya Sagar
2019-04-02 18:31 ` Bjorn Helgaas
2019-04-03 9:43 ` Vidya Sagar
2019-04-03 17:36 ` Bjorn Helgaas
2019-04-04 19:53 ` Vidya Sagar
2019-04-05 18:58 ` Bjorn Helgaas
2019-04-09 11:30 ` Vidya Sagar
2019-04-09 13:26 ` Bjorn Helgaas
2019-04-10 6:10 ` Vidya Sagar
2019-04-10 8:14 ` Liviu Dudau
2019-04-10 9:53 ` Vidya Sagar
2019-04-10 11:35 ` Liviu Dudau
2019-03-26 15:13 ` [PATCH 10/10] arm64: Add Tegra194 PCIe driver to defconfig Vidya Sagar
2019-03-27 10:08 ` Jon Hunter
2019-03-27 10:12 ` Vidya Sagar
2019-03-27 12:26 ` Jon Hunter
2019-03-28 8:19 ` Jisheng Zhang [this message]
2019-04-01 12:45 ` Vidya Sagar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190328161138.1b37d232@xhacker.debian \
--to=jisheng.zhang@synaptics$(echo .)com \
--cc=andy.gross@linaro$(echo .)org \
--cc=bhelgaas@google$(echo .)com \
--cc=bjorn.andersson@linaro$(echo .)org \
--cc=catalin.marinas@arm$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=enric.balletbo@collabora$(echo .)com \
--cc=ezequiel@collabora$(echo .)com \
--cc=gustavo.pimentel@synopsys$(echo .)com \
--cc=hayashi.kunihiko@socionext$(echo .)com \
--cc=heiko@sntech$(echo .)de \
--cc=horms+renesas@verge$(echo .)net.au \
--cc=jagan@amarulasolutions$(echo .)com \
--cc=jingoohan1@gmail$(echo .)com \
--cc=jonathanh@nvidia$(echo .)com \
--cc=kishon@ti$(echo .)com \
--cc=krzk@kernel$(echo .)org \
--cc=kthota@nvidia$(echo .)com \
--cc=l.stach@pengutronix$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linux-tegra@vger$(echo .)kernel.org \
--cc=liviu.dudau@arm$(echo .)com \
--cc=lorenzo.pieralisi@arm$(echo .)com \
--cc=marc.w.gonzalez@free$(echo .)fr \
--cc=mark.rutland@arm$(echo .)com \
--cc=maxime.ripard@bootlin$(echo .)com \
--cc=mmaddireddy@nvidia$(echo .)com \
--cc=mperttunen@nvidia$(echo .)com \
--cc=olof@lixom$(echo .)net \
--cc=robh+dt@kernel$(echo .)org \
--cc=shawn.lin@rock-chips$(echo .)com \
--cc=skomatineni@nvidia$(echo .)com \
--cc=spujar@nvidia$(echo .)com \
--cc=stefan.wahren@i2se$(echo .)com \
--cc=thierry.reding@gmail$(echo .)com \
--cc=tiwai@suse$(echo .)de \
--cc=tpiepho@impinj$(echo .)com \
--cc=vidyas@nvidia$(echo .)com \
--cc=will.deacon@arm$(echo .)com \
--cc=xiaowei.bao@nxp$(echo .)com \
--cc=yue.wang@amlogic$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox