Subject: Re: [PATCH 1/1] arm64: Use defines instead of magic numbers

From: Will Deacon <[email-masked]>
Date: Fri, 5 Apr 2019 13:41:36 +0100

On Fri, Apr 05, 2019 at 11:20:12AM +0100, Alexandru Elisei wrote:
> Following assembly code is not trivial; make it slightly easier to read by
> replacing some of the magic numbers with the defines which are already
> present in sysreg.h.
> 
> Signed-off-by: Alexandru Elisei <[email-masked]>
> ---
>  arch/arm64/include/asm/assembler.h |  4 ++--
>  arch/arm64/kernel/head.S           | 10 +++++-----
>  2 files changed, 7 insertions(+), 7 deletions(-)

How dare you make our early assembly code easier to understand! This brings
us one step closer to being replaced by robots... which can't come soon
enough.

Applied for 5.2.

Will

_______________________________________________
linux-arm-kernel mailing list
[email-masked]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel