Re: [PATCH 07/12] arm64: dts: allwinner: orange-pi-3: Enable ethernet

From: Maxime Ripard <maxime.ripard@bootlin•com>
To: linux-sunxi@googlegroups•com, Chen-Yu Tsai <wens@csie•org>,
	Rob Herring <robh+dt@kernel•org>,
	Linus Walleij <linus.walleij@linaro•org>,
	David Airlie <airlied@linux•ie>, Daniel Vetter <daniel@ffwll•ch>,
	Mark Rutland <mark.rutland@arm•com>,
	Giuseppe Cavallaro <peppe.cavallaro@st•com>,
	Alexandre Torgue <alexandre.torgue@st•com>,
	Jose Abreu <joabreu@synopsys•com>,
	"David S. Miller" <davem@davemloft•net>,
	Maxime Coquelin <mcoquelin.stm32@gmail•com>,
	Arend van Spriel <arend.vanspriel@broadcom•com>,
	Franky Lin <franky.lin@broadcom•com>,
	Hante Meuleman <hante.meuleman@broadcom•com>,
	Chi-Hsien Lin <chi-hsien.lin@cypress•com>,
	Wright Feng <wright.feng@cypress•com>,
	Kalle Valo <kvalo@codeaurora•org>,
	Naveen Gupta <naveen.gupta@cypress•com>,
	dri-devel@lists•freedesktop.org, devicetree@vger•kernel.org,
	linux-arm-kernel@lists•infradead.org,
	linux-kernel@vger•kernel.org, netdev@vger•kernel.org,
	linux-stm32@st-md-mailman•stormreply.com,
	linux-wireless@vger•kernel.org,
	brcm80211-dev-list.pdl@broadcom•com,
	brcm80211-dev-list@cypress•com, linux-gpio@vger•kernel.org
Subject: Re: [PATCH 07/12] arm64: dts: allwinner: orange-pi-3: Enable ethernet
Date: Tue, 9 Apr 2019 09:23:40 +0200	[thread overview]
Message-ID: <20190409072340.lndjtgy7o7y2b76z@flea> (raw)
In-Reply-To: <20190408232232.fsl2ddthwo2rr4ql@core.my.home>


[-- Attachment #1.1: Type: text/plain, Size: 3081 bytes --]

On Tue, Apr 09, 2019 at 01:22:32AM +0200, Ondřej Jirman wrote:
> On Mon, Apr 08, 2019 at 09:40:42AM +0200, Maxime Ripard wrote:
> > On Sat, Apr 06, 2019 at 01:45:09AM +0200, megous@megous•com wrote:
> > > From: Ondrej Jirman <megous@megous•com>
> > >
> > > Orange Pi 3 has two regulators that power the Realtek RTL8211E.
> > > According to the phy datasheet, both regulators need to be enabled
> > > at the same time, but we can only specify a single phy-supply in
> > > the DT.
> > >
> > > This can be achieved by making one regulator depedning on the
> > > other via vin-supply. While it's not a technically correct
> > > description of the hardware, it achieves the purpose.
> > >
> > > All values of RX/TX delay were tested exhaustively and a middle
> > > one of the working values was chosen.
> > >
> > > Signed-off-by: Ondrej Jirman <megous@megous•com>
> > > ---
> > >  .../dts/allwinner/sun50i-h6-orangepi-3.dts    | 44 +++++++++++++++++++
> > >  1 file changed, 44 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts
> > > index 644946749088..5270142527f5 100644
> > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts
> > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-3.dts
> > > @@ -15,6 +15,7 @@
> > >
> > >  	aliases {
> > >  		serial0 = &uart0;
> > > +		ethernet0 = &emac;
> > >  	};
> > >
> > >  	chosen {
> > > @@ -64,6 +65,27 @@
> > >  		regulator-max-microvolt = <5000000>;
> > >  		regulator-always-on;
> > >  	};
> > > +
> > > +	/*
> > > +	 * The board uses 2.5V RGMII signalling. Power sequence
> > > +	 * to enable the phy is to enable GMAC-2V5 and GMAC-3V3 (aldo2)
> > > +	 * power rails at the same time and to wait 100ms.
> > > +	 */
> > > +	reg_gmac_2v5: gmac-2v5 {
> > > +                compatible = "regulator-fixed";
> > > +                regulator-name = "gmac-2v5";
> > > +                regulator-min-microvolt = <2500000>;
> > > +                regulator-max-microvolt = <2500000>;
> > > +                startup-delay-us = <100000>;
> > > +                enable-active-high;
> > > +                gpio = <&pio 3 6 GPIO_ACTIVE_HIGH>; /* PD6 */
> >
> > Is enable-active-high still needed? It's redundant with the
> > GPIO_ACTIVE_HIGH flag.
>
> Looking at the code, use/non-use of enable-active-high inhibits
> flags specified in gpio property. So the GPIO_ACTIVE_HIGH flag
> is ignored here (had GPIO_ACTIVE_LOW been used, the kernel would
> ignore it too and print a warning).
>
> So enable-active-high is still necessary here.

Too bad :/

> See comment in gpiolib-of.c where this is handled:
>
> /*
>  * The regulator GPIO handles are specified such that the
>  * presence or absence of "enable-active-high" solely controls
>  * the polarity of the GPIO line. Any phandle flags must
>  * be actively ignored.
>  */

Thanks for digging this out

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel