Subject: Re: [PATCH v2 11/36] mtd: Fix typo in mtd_ooblayout_set_databytes() description

From: Miquel Raynal <[email-masked]>
Date: Fri, 3 May 2019 10:18:10 +0200

Hi Boris,

Boris Brezillon <[email-masked]> wrote on Sun, 31 Mar
2019 13:32:46 +0200:

> On Mon,  4 Mar 2019 23:28:16 +0100
> Miquel Raynal <[email-masked]> wrote:
> 
> > Fix a probable copy/paste error: the function works like
> > mtd_ooblayout_set_bytes(), not the *_get_bytes() alternate.
> > 
> > Signed-off-by: Miquel Raynal <[email-masked]>
> > ---
> >  drivers/mtd/mtdcore.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c
> > index 21e3cdc04036..6ed48018163c 100644
> > --- a/drivers/mtd/mtdcore.c
> > +++ b/drivers/mtd/mtdcore.c
> > @@ -1592,7 +1592,7 @@ EXPORT_SYMBOL_GPL(mtd_ooblayout_get_databytes);
> >   * @start: first ECC byte to set
> >   * @nbytes: number of ECC bytes to set  
> 
> Looks like the parameter descriptions are wrong too.

Are you sure? I don't see where.

> 
> >   *
> > - * Works like mtd_ooblayout_get_bytes(), except it acts on free bytes.
> > + * Works like mtd_ooblayout_set_bytes(), except it acts on free bytes.
> >   *
> >   * Returns zero on success, a negative error code otherwise.
> >   */  
> 

Thanks,
Miquèl

_______________________________________________
linux-arm-kernel mailing list
[email-masked]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel