Subject: Re: [PATCH] Remove MODULE_ALIAS() calls that take undefined macro

From: Tony Lindgren <[email-masked]>
Date: Mon, 6 May 2019 14:11:20 -0700

* Daniel Lezcano <[email-masked]> [190506 17:40]:
> On 06/05/2019 19:28, Masahiro Yamada wrote:
> > These files do not define (USBHS_)DRIVER_NAME. Yet, they can be
> > successfully compiled because they are never built as a module by
> > anyone, i.e, the MODULE_ALIAS() calls are always no-op.
> > 
> > A problem showed up when a patch "moduleparam: Save information about
> > built-in modules in separate file" is applied. With this new feature,
> > MODULE_*() are populated even if the callers are built-in.
> > 
> > To avoid the build errors, the lines referencing to the undefined
> > macro must be removed.
> > 
> > The complete fix is to remove all MODULE_* and #include <linux/module.h>
> > like many "make ... explicitly non-modular" commits did.
> > 
> > For now, I am touching the offending lines.
> > 
> > Reported-by: Stephen Rothwell <[email-masked]>
> > Signed-off-by: Masahiro Yamada <[email-masked]>
> > ---
> 
> Acked-by: Daniel Lezcano <[email-masked]>

Thanks, please feel free to merge together with your series:

Acked-by: Tony Lindgren <[email-masked]>

Or if you want me to queue it separately, please let me know.

Regards,

Tony

_______________________________________________
linux-arm-kernel mailing list
[email-masked]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel