From: Matthias Kaehlcke <mka@chromium•org>
To: Doug Anderson <dianders@chromium•org>
Cc: Mark Rutland <mark.rutland@arm•com>,
devicetree@vger•kernel.org, Heiko Stuebner <heiko@sntech•de>,
LKML <linux-kernel@vger•kernel.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists•infradead.org>,
Rob Herring <robh+dt@kernel•org>,
Linux ARM <linux-arm-kernel@lists•infradead.org>
Subject: Re: [PATCH 1/2] dts: rockchip: raise GPU trip point temperature for veyron to 72.5 degC
Date: Wed, 15 May 2019 14:37:03 -0700 [thread overview]
Message-ID: <20190515213703.GE40515@google.com> (raw)
In-Reply-To: <CAD=FV=U19uAGkwTqg-N6_m5WYQ7yMwjQir3TYUsb3SWWOihTOg@mail.gmail.com>
Hi Doug,
thanks for the review!
On Wed, May 15, 2019 at 11:30:24AM -0700, Doug Anderson wrote:
> Hi,
>
> On Wed, May 15, 2019 at 8:31 AM Matthias Kaehlcke <mka@chromium•org> wrote:
>
> > This value matches what is used by the downstream Chrome OS 3.14
> > kernel, the 'official' kernel for veyron devices.
> >
> > Signed-off-by: Matthias Kaehlcke <mka@chromium•org>
> > ---
> > arch/arm/boot/dts/rk3288-veyron.dtsi | 8 ++++++++
> > 1 file changed, 8 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/rk3288-veyron.dtsi b/arch/arm/boot/dts/rk3288-veyron.dtsi
> > index 1252522392c7..169da06e1c09 100644
> > --- a/arch/arm/boot/dts/rk3288-veyron.dtsi
> > +++ b/arch/arm/boot/dts/rk3288-veyron.dtsi
> > @@ -446,6 +446,14 @@
> > status = "okay";
> > };
> >
> > +&gpu_thermal {
> > + trips {
> > + gpu_alert0: gpu_alert0 {
> > + temperature = <72500>; /* millicelsius */
> > + };
> > + };
> > +};
> > +
>
> This should be sorted alphabetically. Thus this should sort right
> after this in rk3288-veyron.dtsi
>
> &gpu {
> mali-supply = <&vdd_gpu>;
> status = "okay";
> };
will do in the next revision.
> Also you don't need to replicate the whole structure? I think the
> above should just be:
>
> &gpu_alert0 {
> temperature = <72500>; /* millicelsius */
> };
ack
> NOTE also that that gpu and cpu critical is 100 C downstream. Should
> we do that too?
I missed this delta, yes let's do this too in this series.
> Ah, but before we do that I guess we'd need to also override the
> "rockchip,hw-tshut-temp" to 125000 to match downstream. I guess that
> could be a separate series?
Yes, the value should at least be higher than the critical trip point,
matching downstream seems to make sense.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-05-15 21:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-15 15:31 [PATCH 1/2] dts: rockchip: raise GPU trip point temperature for veyron to 72.5 degC Matthias Kaehlcke
2019-05-15 15:31 ` [PATCH 2/2] ARM: dts: raise GPU trip point temperature for speedy to 80 degC Matthias Kaehlcke
2019-05-15 18:30 ` Doug Anderson
2019-05-15 21:47 ` Matthias Kaehlcke
2019-05-15 18:30 ` [PATCH 1/2] dts: rockchip: raise GPU trip point temperature for veyron to 72.5 degC Doug Anderson
2019-05-15 21:37 ` Matthias Kaehlcke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190515213703.GE40515@google.com \
--to=mka@chromium$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dianders@chromium$(echo .)org \
--cc=heiko@sntech$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-rockchip@lists$(echo .)infradead.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox