From: Matthias Kaehlcke <mka@chromium•org>
To: Enric Balletbo i Serra <enric.balletbo@collabora•com>
Cc: Mark Rutland <mark.rutland@arm•com>,
devicetree@vger•kernel.org, Heiko Stuebner <heiko@sntech•de>,
linux-kernel@vger•kernel.org,
Douglas Anderson <dianders@chromium•org>,
linux-rockchip@lists•infradead.org,
Rob Herring <robh+dt@kernel•org>, Pavel Machek <pavel@ucw•cz>,
linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH] Revert "ARM: dts: rockchip: set PWM delay backlight settings for Minnie"
Date: Tue, 18 Jun 2019 11:34:55 -0700 [thread overview]
Message-ID: <20190618183455.GU137143@google.com> (raw)
In-Reply-To: <45f94c6a-5bd7-92b0-d23f-ae7e0481935f@collabora.com>
Hi Enric,
On Tue, Jun 18, 2019 at 10:21:52AM +0200, Enric Balletbo i Serra wrote:
> Hi Matthias,
>
> On 15/6/19 0:45, Matthias Kaehlcke wrote:
> > This reverts commit 288ceb85b505c19abe1895df068dda5ed20cf482.
> >
> > According to the commit message the AUO B101EAN01 panel on minnie
> > requires a PWM delay of 200 ms, however this is not what the
> > datasheet says. The datasheet mentions a *max* delay of 200 ms
> > for T2 ("delay from LCDVDD to black video generation") and T3
> > ("delay from LCDVDD to HPD high"), which aren't related to the
> > PWM. The backlight power sequence does not specify min/max
> > constraints for T15 (time from PWM on to BL enable) or T16
> > (time from BL disable to PWM off).
> >
>
> Could you point from where the confusion comes from? I think will be helpful for
> the record. B101EAN01.8 vs B101EAN01.1
sounds good
> > Signed-off-by: Matthias Kaehlcke <mka@chromium•org>
>
> With the above added:
>
> Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora•com>
Thanks!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-06-18 18:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 22:45 [PATCH] Revert "ARM: dts: rockchip: set PWM delay backlight settings for Minnie" Matthias Kaehlcke
2019-06-16 15:41 ` Pavel Machek
2019-06-17 10:08 ` Enric Balletbo i Serra
2019-06-17 16:30 ` Matthias Kaehlcke
2019-06-17 16:16 ` Matthias Kaehlcke
2019-06-18 12:02 ` Pavel Machek
2019-06-18 8:21 ` Enric Balletbo i Serra
2019-06-18 18:34 ` Matthias Kaehlcke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190618183455.GU137143@google.com \
--to=mka@chromium$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dianders@chromium$(echo .)org \
--cc=enric.balletbo@collabora$(echo .)com \
--cc=heiko@sntech$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-rockchip@lists$(echo .)infradead.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=pavel@ucw$(echo .)cz \
--cc=robh+dt@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox