From: Krzysztof Kozlowski <krzk@kernel•org>
To: Kukjin Kim <kgene@kernel•org>,
Krzysztof Kozlowski <krzk@kernel•org>,
Sangbeom Kim <sbkim73@samsung•com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung•com>,
Liam Girdwood <lgirdwood@gmail•com>,
Mark Brown <broonie@kernel•org>, Lee Jones <lee.jones@linaro•org>,
devicetree@vger•kernel.org, linux-arm-kernel@lists•infradead.org,
linux-samsung-soc@vger•kernel.org, linux-kernel@vger•kernel.org
Cc: Sylwester Nawrocki <snawrocki@kernel•org>,
notify@kernel•org, Marek Szyprowski <m.szyprowski@samsung•com>
Subject: [PATCH 1/6] regulator: s2mps11: Consistently use local variable
Date: Thu, 20 Jun 2019 20:35:25 +0200 [thread overview]
Message-ID: <20190620183530.5386-1-krzk@kernel.org> (raw)
The value under 's2mps11->ext_control_gpiod[i]' is assigned to local
variable and used in probe in one place before. Use it consistently
later so code will be easier to read.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel•org>
---
drivers/regulator/s2mps11.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/s2mps11.c b/drivers/regulator/s2mps11.c
index af9bf10b4c33..e155c58061af 100644
--- a/drivers/regulator/s2mps11.c
+++ b/drivers/regulator/s2mps11.c
@@ -1194,7 +1194,7 @@ static int s2mps11_pmic_probe(struct platform_device *pdev)
goto out;
}
- if (s2mps11->ext_control_gpiod[i]) {
+ if (config.ena_gpiod) {
ret = s2mps14_pmic_enable_ext_control(s2mps11,
regulator);
if (ret < 0) {
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2019-06-20 18:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 18:35 Krzysztof Kozlowski [this message]
2019-06-20 18:35 ` [PATCH 2/6] regulator: s2mps11: Reduce number of rdev_get_id() calls Krzysztof Kozlowski
2019-06-24 16:32 ` Applied "regulator: s2mps11: Reduce number of rdev_get_id() calls" to the regulator tree Mark Brown
2019-06-20 18:35 ` [PATCH 3/6] regulator: s2mps11: Add support for disabling S2MPS11 regulators in suspend Krzysztof Kozlowski
2019-06-24 16:32 ` Applied "regulator: s2mps11: Add support for disabling S2MPS11 regulators in suspend" to the regulator tree Mark Brown
2019-06-20 18:35 ` [PATCH 4/6] ARM: dts: exynos: Disable unused buck10 regulator on Odroid HC1 board Krzysztof Kozlowski
2019-06-20 18:35 ` [PATCH 5/6] ARM: dts: exynos: Add regulator suspend configuration to Arndale Octa board Krzysztof Kozlowski
2019-06-20 18:35 ` [PATCH 6/6] ARM: dts: exynos: Add regulator suspend configuration to Odroid XU3/XU4/HC1 family Krzysztof Kozlowski
2019-06-21 11:13 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190620183530.5386-1-krzk@kernel.org \
--to=krzk@kernel$(echo .)org \
--cc=b.zolnierkie@samsung$(echo .)com \
--cc=broonie@kernel$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=kgene@kernel$(echo .)org \
--cc=lee.jones@linaro$(echo .)org \
--cc=lgirdwood@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-samsung-soc@vger$(echo .)kernel.org \
--cc=m.szyprowski@samsung$(echo .)com \
--cc=notify@kernel$(echo .)org \
--cc=sbkim73@samsung$(echo .)com \
--cc=snawrocki@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox