From: Sam Ravnborg <sam@ravnborg•org>
To: Jitao Shi <jitao.shi@mediatek•com>
Cc: Mark Rutland <mark.rutland@arm•com>,
devicetree@vger•kernel.org, David Airlie <airlied@linux•ie>,
stonea168@163•com, dri-devel@lists•freedesktop.org,
Ajay Kumar <ajaykumar.rs@samsung•com>,
Vincent Palatin <vpalatin@chromium•org>,
cawa.cheng@mediatek•com, yingjoe.chen@mediatek•com,
Thierry Reding <treding@nvidia•com>,
Sean Paul <seanpaul@chromium•org>,
linux-pwm@vger•kernel.org, Pawel Moll <pawel.moll@arm•com>,
Ian Campbell <ijc+devicetree@hellion•org.uk>,
Rob Herring <robh+dt@kernel•org>,
linux-mediatek@lists•infradead.org,
Russell King <rmk+kernel@arm•linux.org.uk>,
Matthias Brugger <matthias.bgg@gmail•com>,
eddie.huang@mediatek•com, linux-arm-kernel@lists•infradead.org,
Rahul Sharma <rahul.sharma@samsung•com>,
srv_heupstream@mediatek•com, linux-kernel@vger•kernel.org,
Sascha Hauer <kernel@pengutronix•de>,
Andy Yan <andy.yan@rock-chips•com>
Subject: Re: [v3 4/4] drm/panel: support for auo, kd101n80-45na wuxga dsi video mode panel
Date: Wed, 26 Jun 2019 09:26:28 +0200 [thread overview]
Message-ID: <20190626072628.GC14541@ravnborg.org> (raw)
In-Reply-To: <20190626025400.109567-5-jitao.shi@mediatek.com>
On Wed, Jun 26, 2019 at 10:54:00AM +0800, Jitao Shi wrote:
> Auo,kd101n80-45na's connector is same as boe,tv101wum-nl6.
> The most codes can be reuse.
> So auo,kd101n80-45na and boe,tv101wum-nl6 use one driver file.
> Add the different parts in driver data.
Very nice consolidation.
Have you considered another filename that better tell this is a driver
for different types of displays?
And the Kconfig text needs some adjustment to tell this driver now
supports an extra type of display.
Sam
>
> Signed-off-by: Jitao Shi <jitao.shi@mediatek•com>
> ---
> .../gpu/drm/panel/panel-boe-tv101wum-nl6.c | 39 +++++++++++++++++++
> 1 file changed, 39 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
> index 30d1f53dcbaf..6ff49f900cd2 100644
> --- a/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
> +++ b/drivers/gpu/drm/panel/panel-boe-tv101wum-nl6.c
> @@ -372,6 +372,15 @@ static const struct panel_init_cmd boe_init_cmd[] = {
> {},
> };
>
> +static const struct panel_init_cmd auo_init_cmd[] = {
> + _INIT_DELAY_CMD(24),
> + _INIT_DCS_CMD(0x11),
> + _INIT_DELAY_CMD(120),
> + _INIT_DCS_CMD(0x29),
> + _INIT_DELAY_CMD(120),
> + {},
> +};
> +
> static inline struct boe_panel *to_boe_panel(struct drm_panel *panel)
> {
> return container_of(panel, struct boe_panel, base);
> @@ -571,6 +580,33 @@ static const struct panel_desc boe_tv101wum_nl6_desc = {
> .init_cmds = boe_init_cmd,
> };
>
> +static const struct drm_display_mode auo_default_mode = {
> + .clock = 157000,
> + .hdisplay = 1200,
> + .hsync_start = 1200 + 80,
> + .hsync_end = 1200 + 80 + 24,
> + .htotal = 1200 + 80 + 24 + 36,
> + .vdisplay = 1920,
> + .vsync_start = 1920 + 16,
> + .vsync_end = 1920 + 16 + 4,
> + .vtotal = 1920 + 16 + 4 + 16,
> + .vrefresh = 60,
> +};
> +
> +static const struct panel_desc auo_kd101n80_45na_desc = {
> + .modes = &auo_default_mode,
> + .bpc = 8,
> + .size = {
> + .width = 135,
> + .height = 216,
> + },
> + .lanes = 4,
> + .format = MIPI_DSI_FMT_RGB888,
> + .mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_SYNC_PULSE |
> + MIPI_DSI_MODE_LPM,
> + .init_cmds = auo_init_cmd,
> +};
> +
> static int boe_panel_get_modes(struct drm_panel *panel)
> {
> struct boe_panel *boe = to_boe_panel(panel);
> @@ -694,6 +730,9 @@ static const struct of_device_id boe_of_match[] = {
> { .compatible = "boe,tv101wum-nl6",
> .data = &boe_tv101wum_nl6_desc
> },
> + { .compatible = "auo,kd101n80-45na",
> + .data = &auo_kd101n80_45na_desc
> + },
> { /* sentinel */ }
> };
> MODULE_DEVICE_TABLE(of, boe_of_match);
> --
> 2.21.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists•freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-06-26 7:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 2:53 [v3 0/4] Add drivers for auo, kd101n80-45na and boe, tv101wum-nl6 panels Jitao Shi
2019-06-26 2:53 ` [v3 1/4] dt-bindngs: display: panel: Add BOE tv101wum-n16 panel bindings Jitao Shi
2019-06-26 7:20 ` Sam Ravnborg
2019-07-22 17:39 ` Rob Herring
2019-07-22 19:11 ` Uwe Kleine-König
2019-06-26 2:53 ` [v3 2/4] drm/panel: support for BOE tv101wum-nl6 wuxga dsi video mode panel Jitao Shi
2019-06-26 7:20 ` Sam Ravnborg
2019-06-26 2:53 ` [v3 3/4] dt-bindings: display: panel: add auo kd101n80-45na panel bindings Jitao Shi
2019-07-22 17:39 ` Rob Herring
2019-06-26 2:54 ` [v3 4/4] drm/panel: support for auo, kd101n80-45na wuxga dsi video mode panel Jitao Shi
2019-06-26 7:26 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190626072628.GC14541@ravnborg.org \
--to=sam@ravnborg$(echo .)org \
--cc=airlied@linux$(echo .)ie \
--cc=ajaykumar.rs@samsung$(echo .)com \
--cc=andy.yan@rock-chips$(echo .)com \
--cc=cawa.cheng@mediatek$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=eddie.huang@mediatek$(echo .)com \
--cc=ijc+devicetree@hellion$(echo .)org.uk \
--cc=jitao.shi@mediatek$(echo .)com \
--cc=kernel@pengutronix$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=linux-pwm@vger$(echo .)kernel.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=pawel.moll@arm$(echo .)com \
--cc=rahul.sharma@samsung$(echo .)com \
--cc=rmk+kernel@arm$(echo .)linux.org.uk \
--cc=robh+dt@kernel$(echo .)org \
--cc=seanpaul@chromium$(echo .)org \
--cc=srv_heupstream@mediatek$(echo .)com \
--cc=stonea168@163$(echo .)com \
--cc=treding@nvidia$(echo .)com \
--cc=vpalatin@chromium$(echo .)org \
--cc=yingjoe.chen@mediatek$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox