From: Bjorn Andersson <bjorn.andersson@linaro•org>
To: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro•org>
Cc: mark.rutland@arm•com, heiko@sntech•de, mturquette@baylibre•com,
will.deacon@arm•com, david.brown@linaro•org,
linux-clk@vger•kernel.org, jassisinghbrar@gmail•com,
sibis@codeaurora•org, jagan@amarulasolutions•com,
devicetree@vger•kernel.org, niklas.cassel@linaro•org,
arnd@arndb•de, linux-arm-msm@vger•kernel.org, olof@lixom•net,
robh+dt@kernel•org, horms+renesas@verge•net.au,
linux-arm-kernel@lists•infradead.org, sboyd@kernel•org,
linux-kernel@vger•kernel.org, amit.kucheria@linaro•org,
vkoul@kernel•org, khasim.mohammed@linaro•org,
enric.balletbo@collabora•com, georgi.djakov@linaro•org
Subject: Re: [PATCH v3 07/14] clk: qcom: hfpll: register as clock provider
Date: Thu, 11 Jul 2019 08:07:54 -0700 [thread overview]
Message-ID: <20190711150754.GH7234@tuxbook-pro> (raw)
In-Reply-To: <20190625164733.11091-8-jorge.ramirez-ortiz@linaro.org>
On Tue 25 Jun 09:47 PDT 2019, Jorge Ramirez-Ortiz wrote:
> Make the output of the high frequency pll a clock provider.
> On the QCS404 this PLL controls cpu frequency scaling.
>
> Co-developed-by: Niklas Cassel <niklas.cassel@linaro•org>
> Signed-off-by: Niklas Cassel <niklas.cassel@linaro•org>
> Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro•org>
> Acked-by: Stephen Boyd <sboyd@kernel•org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro•org>
> ---
> drivers/clk/qcom/hfpll.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/clk/qcom/hfpll.c b/drivers/clk/qcom/hfpll.c
> index 87b7f46d27e0..0ffed0d41c50 100644
> --- a/drivers/clk/qcom/hfpll.c
> +++ b/drivers/clk/qcom/hfpll.c
> @@ -53,6 +53,7 @@ static int qcom_hfpll_probe(struct platform_device *pdev)
> struct regmap *regmap;
> struct clk_hfpll *h;
> struct clk *pclk;
> + int ret;
> struct clk_init_data init = {
> .parent_names = (const char *[]){ "xo" },
> .num_parents = 1,
> @@ -87,7 +88,14 @@ static int qcom_hfpll_probe(struct platform_device *pdev)
> h->clkr.hw.init = &init;
> spin_lock_init(&h->lock);
>
> - return devm_clk_register_regmap(&pdev->dev, &h->clkr);
> + ret = devm_clk_register_regmap(dev, &h->clkr);
> + if (ret) {
> + dev_err(dev, "failed to register regmap clock: %d\n", ret);
> + return ret;
> + }
> +
> + return devm_of_clk_add_hw_provider(dev, of_clk_hw_simple_get,
> + &h->clkr.hw);
> }
>
> static struct platform_driver qcom_hfpll_driver = {
> --
> 2.21.0
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-11 15:06 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 16:47 [PATCH v3 00/14] Support CPU frequency scaling on QCS404 Jorge Ramirez-Ortiz
2019-06-25 16:47 ` [PATCH v3 01/14] clk: qcom: gcc: limit GPLL0_AO_OUT operating frequency Jorge Ramirez-Ortiz
2019-07-11 15:30 ` Bjorn Andersson
2019-06-25 16:47 ` [PATCH v3 02/14] mbox: qcom: add APCS child device for QCS404 Jorge Ramirez-Ortiz
2019-07-11 14:44 ` Bjorn Andersson
2019-07-31 14:10 ` Jorge Ramirez
2019-06-25 16:47 ` [PATCH v3 03/14] mbox: qcom: replace integer with valid macro Jorge Ramirez-Ortiz
2019-07-11 14:37 ` Bjorn Andersson
2019-06-25 16:47 ` [PATCH v3 04/14] dt-bindings: mailbox: qcom: Add clock-name optional property Jorge Ramirez-Ortiz
2019-07-11 14:45 ` Bjorn Andersson
2019-06-25 16:47 ` [PATCH v3 05/14] clk: qcom: apcs-msm8916: get parent clock names from DT Jorge Ramirez-Ortiz
2019-07-11 14:58 ` Bjorn Andersson
2019-06-25 16:47 ` [PATCH v3 06/14] clk: qcom: hfpll: " Jorge Ramirez-Ortiz
2019-07-11 15:07 ` Bjorn Andersson
2019-06-25 16:47 ` [PATCH v3 07/14] clk: qcom: hfpll: register as clock provider Jorge Ramirez-Ortiz
2019-07-11 15:07 ` Bjorn Andersson [this message]
2019-06-25 16:47 ` [PATCH v3 08/14] clk: qcom: hfpll: CLK_IGNORE_UNUSED Jorge Ramirez-Ortiz
2019-07-11 15:16 ` Bjorn Andersson
2019-07-31 14:30 ` Jorge Ramirez
2019-06-25 16:47 ` [PATCH v3 09/14] arm64: dts: qcom: msm8916: Add the clocks for the APCS mux/divider Jorge Ramirez-Ortiz
2019-07-11 15:24 ` Bjorn Andersson
2019-06-25 16:47 ` [PATCH v3 10/14] arm64: dts: qcom: qcs404: Add OPP table Jorge Ramirez-Ortiz
2019-07-11 15:25 ` Bjorn Andersson
2019-06-25 16:47 ` [PATCH v3 11/14] arm64: dts: qcom: qcs404: Add HFPLL node Jorge Ramirez-Ortiz
2019-07-11 15:25 ` Bjorn Andersson
2019-06-25 16:47 ` [PATCH v3 12/14] arm64: dts: qcom: qcs404: Add the clocks for APCS mux/divider Jorge Ramirez-Ortiz
2019-07-11 15:27 ` Bjorn Andersson
2019-06-25 16:47 ` [PATCH v3 13/14] arm64: dts: qcom: qcs404: Add DVFS support Jorge Ramirez-Ortiz
2019-06-26 9:08 ` Niklas Cassel
2019-06-26 9:10 ` Niklas Cassel
2019-07-11 15:29 ` Bjorn Andersson
2019-06-25 16:47 ` [PATCH v3 14/14] arm64: defconfig: Enable HFPLL Jorge Ramirez-Ortiz
2019-07-11 15:27 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190711150754.GH7234@tuxbook-pro \
--to=bjorn.andersson@linaro$(echo .)org \
--cc=amit.kucheria@linaro$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=david.brown@linaro$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=enric.balletbo@collabora$(echo .)com \
--cc=georgi.djakov@linaro$(echo .)org \
--cc=heiko@sntech$(echo .)de \
--cc=horms+renesas@verge$(echo .)net.au \
--cc=jagan@amarulasolutions$(echo .)com \
--cc=jassisinghbrar@gmail$(echo .)com \
--cc=jorge.ramirez-ortiz@linaro$(echo .)org \
--cc=khasim.mohammed@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-clk@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=mturquette@baylibre$(echo .)com \
--cc=niklas.cassel@linaro$(echo .)org \
--cc=olof@lixom$(echo .)net \
--cc=robh+dt@kernel$(echo .)org \
--cc=sboyd@kernel$(echo .)org \
--cc=sibis@codeaurora$(echo .)org \
--cc=vkoul@kernel$(echo .)org \
--cc=will.deacon@arm$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox