From: Sam Ravnborg <sam@ravnborg•org>
To: Andrzej Pietrasiewicz <andrzej.p@collabora•com>
Cc: "Neil Armstrong" <narmstrong@baylibre•com>,
"Maxime Ripard" <maxime.ripard@bootlin•com>,
dri-devel@lists•freedesktop.org,
"Douglas Anderson" <dianders@chromium•org>,
linux-tegra@vger•kernel.org,
"Thierry Reding" <thierry.reding@gmail•com>,
"Laurent Pinchart" <Laurent.pinchart@ideasonboard•com>,
kernel@collabora•com, linux-samsung-soc@vger•kernel.org,
linux-rockchip@lists•infradead.org,
"Vincent Abriou" <vincent.abriou@st•com>,
"Krzysztof Kozlowski" <krzk@kernel•org>,
"Jonathan Hunter" <jonathanh@nvidia•com>,
"David Airlie" <airlied@linux•ie>, "Chen-Yu Tsai" <wens@csie•org>,
"Kukjin Kim" <kgene@kernel•org>,
"NXP Linux Team" <linux-imx@nxp•com>,
"Dave Airlie" <airlied@redhat•com>,
freedreno@lists•freedesktop.org,
"Pengutronix Kernel Team" <kernel@pengutronix•de>,
"Jonas Karlman" <jonas@kwiboo•se>,
linux-arm-msm@vger•kernel.org, intel-gfx@lists•freedesktop.org,
"Jyri Sarha" <jsarha@ti•com>,
"Alexios Zavras" <alexios.zavras@intel•com>,
"Mamta Shukla" <mamtashukla555@gmail•com>,
linux-mediatek@lists•infradead.org,
"Rodrigo Vivi" <rodrigo.vivi@intel•com>,
"Matthias Brugger" <matthias.bgg@gmail•com>,
"Thomas Gleixner" <tglx@linutronix•de>,
"Sean Paul" <sean@poorly•run>,
linux-arm-kernel@lists•infradead.org,
"Jernej Skrabec" <jernej.skrabec@siol•net>,
amd-gfx@lists•freedesktop.org,
"Tomi Valkeinen" <tomi.valkeinen@ti•com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation•org>,
"Seung-Woo Kim" <sw0312.kim@samsung•com>,
linux-kernel@vger•kernel.org,
"Todor Tomov" <todor.tomov@linaro•org>,
"Kyungmin Park" <kyungmin.park@samsung•com>,
"Huang Rui" <ray.huang@amd•com>,
"Thomas Zimmermann" <tzimmermann@suse•de>,
"Alex Deucher" <alexander.deucher@amd•com>,
"Shawn Guo" <shawnguo@kernel•org>,
"Christian König" <christian.koenig@amd•com>,
"Gerd Hoffmann" <kraxel@redhat•com>
Subject: Re: [PATCH v4 14/23] drm/tilcdc: Provide ddc symlink in connector sysfs directory
Date: Tue, 23 Jul 2019 17:19:39 +0200 [thread overview]
Message-ID: <20190723151939.GA13718@ravnborg.org> (raw)
In-Reply-To: <3ad60be5-49cf-4017-4b74-53a2d6272deb@collabora.com>
Hi Andrej.
On Tue, Jul 23, 2019 at 02:44:50PM +0200, Andrzej Pietrasiewicz wrote:
> Hi Sam,
>
> W dniu 23.07.2019 o 11:05, Sam Ravnborg pisze:
> > Hi Andrzej
> >
> > On Thu, Jul 11, 2019 at 01:26:41PM +0200, Andrzej Pietrasiewicz wrote:
> > > Use the ddc pointer provided by the generic connector.
> > >
> > > Signed-off-by: Andrzej Pietrasiewicz <andrzej.p@collabora•com>
> > > ---
> > > drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
> > > index 62d014c20988..c373edb95666 100644
> > > --- a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
> > > +++ b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
> > > @@ -219,6 +219,7 @@ static struct drm_connector *tfp410_connector_create(struct drm_device *dev,
> > > tfp410_connector->mod = mod;
> > > connector = &tfp410_connector->base;
> > > + connector->ddc = mod->i2c;
> > > drm_connector_init(dev, connector, &tfp410_connector_funcs,
> > > DRM_MODE_CONNECTOR_DVID);
> >
> > When reading this code, it looks strange that we set connector->ddc
> > *before* the call to init the connector.
> > One could risk that drm_connector_init() used memset(..) to clear all
> > fields or so, and it would break this order.
>
> I verified the code of drm_connector_init() and cannot find any memset()
> invocations there. What is your actual concern?
My concern is that drm_connector_init() maybe sometime in the future
will init all fileds in drm_connector, so we loose any assingments
done to drm_connector from *before* we called the init function.
Moving the assignment to after drm_connector_init() would not
let us depend on the actual implmentation of drm_connector_init().
Sam
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-23 15:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1562843413.git.andrzej.p@collabora.com>
[not found] ` <d1d415022c598fb7acd033f0f322dd67250adaa9.1562843413.git.andrzej.p@collabora.com>
2019-07-23 9:05 ` [PATCH v4 14/23] drm/tilcdc: Provide ddc symlink in connector sysfs directory Sam Ravnborg
2019-07-23 12:44 ` Andrzej Pietrasiewicz
2019-07-23 15:19 ` Sam Ravnborg [this message]
2019-07-24 8:01 ` Thomas Zimmermann
2019-07-24 8:51 ` Andrzej Pietrasiewicz
2019-07-31 19:39 ` Ezequiel Garcia
[not found] ` <d32a6b1f0a3b79f1fbc8d0894080908526f6e61e.1562843413.git.andrzej.p@collabora.com>
2019-07-23 9:07 ` [PATCH v4 16/23] drm/mgag200: " Sam Ravnborg
[not found] ` <d3651bd2fd8ba69b8380304bca4c629a8c1da4e9.1562843413.git.andrzej.p@collabora.com>
2019-07-23 9:09 ` [PATCH v4 17/23] drm/ast: " Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190723151939.GA13718@ravnborg.org \
--to=sam@ravnborg$(echo .)org \
--cc=Laurent.pinchart@ideasonboard$(echo .)com \
--cc=airlied@linux$(echo .)ie \
--cc=airlied@redhat$(echo .)com \
--cc=alexander.deucher@amd$(echo .)com \
--cc=alexios.zavras@intel$(echo .)com \
--cc=amd-gfx@lists$(echo .)freedesktop.org \
--cc=andrzej.p@collabora$(echo .)com \
--cc=christian.koenig@amd$(echo .)com \
--cc=dianders@chromium$(echo .)org \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=freedreno@lists$(echo .)freedesktop.org \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=intel-gfx@lists$(echo .)freedesktop.org \
--cc=jernej.skrabec@siol$(echo .)net \
--cc=jonas@kwiboo$(echo .)se \
--cc=jonathanh@nvidia$(echo .)com \
--cc=jsarha@ti$(echo .)com \
--cc=kernel@collabora$(echo .)com \
--cc=kernel@pengutronix$(echo .)de \
--cc=kgene@kernel$(echo .)org \
--cc=kraxel@redhat$(echo .)com \
--cc=krzk@kernel$(echo .)org \
--cc=kyungmin.park@samsung$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-imx@nxp$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=linux-rockchip@lists$(echo .)infradead.org \
--cc=linux-samsung-soc@vger$(echo .)kernel.org \
--cc=linux-tegra@vger$(echo .)kernel.org \
--cc=mamtashukla555@gmail$(echo .)com \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=maxime.ripard@bootlin$(echo .)com \
--cc=narmstrong@baylibre$(echo .)com \
--cc=ray.huang@amd$(echo .)com \
--cc=rodrigo.vivi@intel$(echo .)com \
--cc=sean@poorly$(echo .)run \
--cc=shawnguo@kernel$(echo .)org \
--cc=sw0312.kim@samsung$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=thierry.reding@gmail$(echo .)com \
--cc=todor.tomov@linaro$(echo .)org \
--cc=tomi.valkeinen@ti$(echo .)com \
--cc=tzimmermann@suse$(echo .)de \
--cc=vincent.abriou@st$(echo .)com \
--cc=wens@csie$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox