[PATCH v1 10/16] drm/panel: ili9322: move bus_flags to get_modes()

From: Sam Ravnborg <sam@ravnborg•org>
To: dri-devel@lists•freedesktop.org,
	Thierry Reding <thierry.reding@gmail•com>
Cc: Neil Armstrong <narmstrong@baylibre•com>,
	David Airlie <airlied@linux•ie>,
	Linus Walleij <linus.walleij@linaro•org>,
	Stefan Agner <stefan@agner•ch>,
	Andrzej Hajda <a.hajda@samsung•com>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard•com>,
	Benjamin Gaignard <benjamin.gaignard@linaro•org>,
	Fabio Estevam <festevam@gmail•com>, Marek Vasut <marex@denx•de>,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard•com>,
	Joonyoung Shim <jy0922.shim@samsung•com>,
	Sam Ravnborg <sam@ravnborg•org>,
	Krzysztof Kozlowski <krzk@kernel•org>,
	Jonathan Hunter <jonathanh@nvidia•com>,
	Maxime Ripard <maxime.ripard@bootlin•com>,
	Kukjin Kim <kgene@kernel•org>,
	Allison Randal <allison@lohutok•net>,
	Philipp Zabel <p.zabel@pengutronix•de>,
	NXP Linux Team <linux-imx@nxp•com>,
	Pengutronix Kernel Team <kernel@pengutronix•de>,
	Jonas Karlman <jonas@kwiboo•se>,
	Sascha Hauer <s.hauer@pengutronix•de>,
	Alison Wang <alison.wang@nxp•com>,
	Maarten Lankhorst <maarten.lankhorst@linux•intel.com>,
	Gwan-gyeong Mun <gwan-gyeong.mun@intel•com>,
	Inki Dae <inki.dae@samsung•com>,
	Alexios Zavras <alexios.zavras@intel•com>,
	linux-samsung-soc@vger•kernel.org, linux-tegra@vger•kernel.org,
	Thomas Gleixner <tglx@linutronix•de>, Sean Paul <sean@poorly•run>,
	linux-arm-kernel@lists•infradead.org,
	Jernej Skrabec <jernej.skrabec@siol•net>,
	Shawn Guo <shawnguo@kernel•org>,
	Seung-Woo Kim <sw0312.kim@samsung•com>,
	Vincent Abriou <vincent.abriou@st•com>,
	Kyungmin Park <kyungmin.park@samsung•com>,
	Daniel Vetter <daniel@ffwll•ch>, Enrico Weigelt <info@metux•net>
Subject: [PATCH v1 10/16] drm/panel: ili9322: move bus_flags to get_modes()
Date: Sun,  4 Aug 2019 22:16:31 +0200	[thread overview]
Message-ID: <20190804201637.1240-11-sam@ravnborg.org> (raw)
In-Reply-To: <20190804201637.1240-1-sam@ravnborg.org>

To prepare the driver to receive drm_connector only in the get_modes()
callback, move bus_flags handling to ili9322_get_modes().

Signed-off-by: Sam Ravnborg <sam@ravnborg•org>
Cc: Thierry Reding <thierry.reding@gmail•com>
Cc: Sam Ravnborg <sam@ravnborg•org>
---
 drivers/gpu/drm/panel/panel-ilitek-ili9322.c | 34 +++++++++-----------
 1 file changed, 16 insertions(+), 18 deletions(-)

diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9322.c b/drivers/gpu/drm/panel/panel-ilitek-ili9322.c
index 53dd1e128795..3c58f63adbf7 100644
--- a/drivers/gpu/drm/panel/panel-ilitek-ili9322.c
+++ b/drivers/gpu/drm/panel/panel-ilitek-ili9322.c
@@ -349,7 +349,6 @@ static const struct regmap_config ili9322_regmap_config = {
 
 static int ili9322_init(struct drm_panel *panel, struct ili9322 *ili)
 {
-	struct drm_connector *connector = panel->connector;
 	u8 reg;
 	int ret;
 	int i;
@@ -407,23 +406,11 @@ static int ili9322_init(struct drm_panel *panel, struct ili9322 *ili)
 	 * Polarity and inverted color order for RGB input.
 	 * None of this applies in the BT.656 mode.
 	 */
-	if (ili->conf->dclk_active_high) {
+	reg = 0;
+	if (ili->conf->dclk_active_high)
 		reg = ILI9322_POL_DCLK;
-		connector->display_info.bus_flags |=
-			DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE;
-	} else {
-		reg = 0;
-		connector->display_info.bus_flags |=
-			DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE;
-	}
-	if (ili->conf->de_active_high) {
+	if (ili->conf->de_active_high)
 		reg |= ILI9322_POL_DE;
-		connector->display_info.bus_flags |=
-			DRM_BUS_FLAG_DE_HIGH;
-	} else {
-		connector->display_info.bus_flags |=
-			DRM_BUS_FLAG_DE_LOW;
-	}
 	if (ili->conf->hsync_active_high)
 		reg |= ILI9322_POL_HSYNC;
 	if (ili->conf->vsync_active_high)
@@ -659,9 +646,20 @@ static int ili9322_get_modes(struct drm_panel *panel)
 	struct drm_connector *connector = panel->connector;
 	struct ili9322 *ili = panel_to_ili9322(panel);
 	struct drm_display_mode *mode;
+	struct drm_display_info *info;
+
+	info = &connector->display_info;
+	info->width_mm = ili->conf->width_mm;
+	info->height_mm = ili->conf->height_mm;
+	if (ili->conf->dclk_active_high)
+		info->bus_flags |= DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE;
+	else
+		info->bus_flags |= DRM_BUS_FLAG_PIXDATA_DRIVE_NEGEDGE;
 
-	connector->display_info.width_mm = ili->conf->width_mm;
-	connector->display_info.height_mm = ili->conf->height_mm;
+	if (ili->conf->de_active_high)
+		info->bus_flags |= DRM_BUS_FLAG_DE_HIGH;
+	else
+		info->bus_flags |= DRM_BUS_FLAG_DE_LOW;
 
 	switch (ili->input) {
 	case ILI9322_INPUT_SRGB_DUMMY_320X240:
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
