From: Catalin Marinas <catalin.marinas@arm•com>
To: Steve Capper <Steve.Capper@arm•com>
Cc: "crecklin@redhat•com" <crecklin@redhat•com>,
"ard.biesheuvel@linaro•org" <ard.biesheuvel@linaro•org>,
"maz@kernel•org" <maz@kernel•org>,
"bhsharma@redhat•com" <bhsharma@redhat•com>, nd <nd@arm•com>,
"will@kernel•org" <will@kernel•org>,
"linux-arm-kernel@lists•infradead.org"
<linux-arm-kernel@lists•infradead.org>
Subject: Re: [PATCH V4 06/11] arm64: mm: Introduce VA_BITS_ACTUAL
Date: Tue, 6 Aug 2019 15:48:33 +0100 [thread overview]
Message-ID: <20190806144833.GE30716@arrakis.emea.arm.com> (raw)
In-Reply-To: <20190806113202.GA11778@capper-ampere.manchester.arm.com>
On Tue, Aug 06, 2019 at 11:32:04AM +0000, Steve Capper wrote:
> On Mon, Aug 05, 2019 at 06:26:43PM +0100, Catalin Marinas wrote:
> > On Mon, Jul 29, 2019 at 05:21:12PM +0100, Steve Capper wrote:
> > > diff --git a/arch/arm64/include/asm/memory.h b/arch/arm64/include/asm/memory.h
> > > index a8a91a573bff..93341f4fe840 100644
> > > --- a/arch/arm64/include/asm/memory.h
> > > +++ b/arch/arm64/include/asm/memory.h
> > > @@ -37,8 +37,6 @@
> > > * VA_START - the first kernel virtual address.
> > > */
> > > #define VA_BITS (CONFIG_ARM64_VA_BITS)
> > > -#define VA_START (UL(0xffffffffffffffff) - \
> > > - (UL(1) << (VA_BITS - 1)) + 1)
> > > #define PAGE_OFFSET (UL(0xffffffffffffffff) - \
> > > (UL(1) << VA_BITS) + 1)
> > > #define KIMAGE_VADDR (MODULES_END)
> > > @@ -166,10 +164,14 @@
> > > #endif
> > >
> > > #ifndef __ASSEMBLY__
> > > +extern u64 vabits_actual;
> > > +#define VA_BITS_ACTUAL ({vabits_actual;})
> >
> > Why not use the variable vabits_actual directly instead of defining a
> > macro?
>
> I thought that it would look better to have an uppercase name for the
> actual VA bits to match the existing code style for VA_BITS.
>
> I can just rename vabits_actual => VA_BITS_ACTUAL and get rid of the
> macro?
By tradition we use uppercase for macros and lowercase for variables. So
I'd definitely keep the variable lowercase.
If you prefer to keep the macro as well, fine by me, I don't think we
should bikeshed here.
--
Catalin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-06 14:49 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-29 16:21 [PATCH V4 00/11] 52-bit kernel + user VAs Steve Capper
2019-07-29 16:21 ` [PATCH V4 01/11] arm64: mm: Remove bit-masking optimisations for PAGE_OFFSET and VMEMMAP_START Steve Capper
2019-08-05 11:07 ` Catalin Marinas
2019-07-29 16:21 ` [PATCH V4 02/11] arm64: mm: Flip kernel VA space Steve Capper
2019-08-05 11:29 ` Catalin Marinas
2019-08-05 11:50 ` Steve Capper
2019-07-29 16:21 ` [PATCH V4 03/11] arm64: kasan: Switch to using KASAN_SHADOW_OFFSET Steve Capper
2019-08-05 16:37 ` Catalin Marinas
2019-08-06 9:05 ` Steve Capper
2019-07-29 16:21 ` [PATCH V4 04/11] arm64: dump: De-constify VA_START and KASAN_SHADOW_START Steve Capper
2019-08-05 16:38 ` Catalin Marinas
2019-07-29 16:21 ` [PATCH V4 05/11] arm64: mm: Introduce VA_BITS_MIN Steve Capper
2019-08-05 17:17 ` Catalin Marinas
2019-08-05 17:20 ` Catalin Marinas
2019-08-06 9:11 ` Steve Capper
2019-07-29 16:21 ` [PATCH V4 06/11] arm64: mm: Introduce VA_BITS_ACTUAL Steve Capper
2019-08-05 17:26 ` Catalin Marinas
2019-08-06 11:32 ` Steve Capper
2019-08-06 14:48 ` Catalin Marinas [this message]
2019-08-07 13:27 ` Steve Capper
2019-07-29 16:21 ` [PATCH V4 07/11] arm64: mm: Logic to make offset_ttbr1 conditional Steve Capper
2019-08-05 17:06 ` Catalin Marinas
2019-07-29 16:21 ` [PATCH V4 08/11] arm64: mm: Separate out vmemmap Steve Capper
2019-08-05 17:07 ` Catalin Marinas
2019-07-29 16:21 ` [PATCH V4 09/11] arm64: mm: Modify calculation of VMEMMAP_SIZE Steve Capper
2019-08-05 17:10 ` Catalin Marinas
2019-07-29 16:21 ` [PATCH V4 10/11] arm64: mm: Introduce 52-bit Kernel VAs Steve Capper
2019-08-05 17:27 ` Catalin Marinas
2019-08-06 14:55 ` Catalin Marinas
2019-08-06 14:58 ` Catalin Marinas
2019-07-29 16:21 ` [PATCH V4 11/11] docs: arm64: Add layout and 52-bit info to memory document Steve Capper
2019-08-06 15:27 ` Catalin Marinas
2019-08-07 13:29 ` Steve Capper
2019-08-07 14:55 ` Will Deacon
2019-08-07 15:57 ` Steve Capper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190806144833.GE30716@arrakis.emea.arm.com \
--to=catalin.marinas@arm$(echo .)com \
--cc=Steve.Capper@arm$(echo .)com \
--cc=ard.biesheuvel@linaro$(echo .)org \
--cc=bhsharma@redhat$(echo .)com \
--cc=crecklin@redhat$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=maz@kernel$(echo .)org \
--cc=nd@arm$(echo .)com \
--cc=will@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox